rapid7/metasploit-framework

View on GitHub
modules/auxiliary/scanner/oracle/xdb_sid_brute.rb

Summary

Maintainability
F
4 days
Test Coverage

Method run_host has a Cognitive Complexity of 93 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(ip)
    begin

    res = send_request_raw({
      'uri'     => '/oradb/PUBLIC/GLOBAL_NAME',
Severity: Minor
Found in modules/auxiliary/scanner/oracle/xdb_sid_brute.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_host has 307 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    begin

    res = send_request_raw({
      'uri'     => '/oradb/PUBLIC/GLOBAL_NAME',
Severity: Major
Found in modules/auxiliary/scanner/oracle/xdb_sid_brute.rb - About 1 day to fix

    File xdb_sid_brute.rb has 335 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Auxiliary
      include Msf::Auxiliary::Report
      include Msf::Exploit::Remote::HttpClient
      include Msf::Auxiliary::Scanner
    
    
    Severity: Minor
    Found in modules/auxiliary/scanner/oracle/xdb_sid_brute.rb - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  report_note(
                    :host => datastore['RHOST'],
                    :proto => 'tcp',
                    :sname => 'xdb',
                    :port => datastore['RPORT'],
      Severity: Minor
      Found in modules/auxiliary/scanner/oracle/xdb_sid_brute.rb and 1 other location - About 20 mins to fix
      modules/auxiliary/scanner/oracle/xdb_sid_brute.rb on lines 256..264

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  report_note(
                    :host => datastore['RHOST'],
                    :proto => 'tcp',
                    :sname => 'xdb',
                    :port => datastore['RPORT'],
      Severity: Minor
      Found in modules/auxiliary/scanner/oracle/xdb_sid_brute.rb and 1 other location - About 20 mins to fix
      modules/auxiliary/scanner/oracle/xdb_sid_brute.rb on lines 266..274

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            res = send_request_raw({
              'uri'     => '/oradb/PUBLIC/USER_PASSWORD_LIMITS',
              'version' => '1.1',
              'method'  => 'GET',
              'read_max_data' => (1024*1024*10),
      Severity: Minor
      Found in modules/auxiliary/scanner/oracle/xdb_sid_brute.rb and 1 other location - About 15 mins to fix
      modules/auxiliary/scanner/oracle/xdb_sid_brute.rb on lines 228..237

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            res = send_request_raw({
              'uri'     => '/oradb/PUBLIC/DBA_USERS',
              'version' => '1.1',
              'method'  => 'GET',
              'read_max_data' => (1024*1024*10),
      Severity: Minor
      Found in modules/auxiliary/scanner/oracle/xdb_sid_brute.rb and 1 other location - About 15 mins to fix
      modules/auxiliary/scanner/oracle/xdb_sid_brute.rb on lines 280..289

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status