rapid7/metasploit-framework

View on GitHub
modules/auxiliary/scanner/snmp/snmp_enum.rb

Summary

Maintainability
F
1 wk
Test Coverage

Method run_host has 707 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)

    begin
      snmp = connect_snmp

Severity: Major
Found in modules/auxiliary/scanner/snmp/snmp_enum.rb - About 3 days to fix

    Method run_host has a Cognitive Complexity of 143 (exceeds 5 allowed). Consider refactoring.
    Open

      def run_host(ip)
    
        begin
          snmp = connect_snmp
    
    
    Severity: Minor
    Found in modules/auxiliary/scanner/snmp/snmp_enum.rb - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File snmp_enum.rb has 745 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Auxiliary
      include Msf::Exploit::Remote::SNMPClient
      include Msf::Auxiliary::Report
      include Msf::Auxiliary::Scanner
    
    
    Severity: Major
    Found in modules/auxiliary/scanner/snmp/snmp_enum.rb - About 1 day to fix

      Consider simplifying this complex logical expression.
      Open

            if (str.empty? or str =~ /Null/ or str =~ /^noSuch/)
              output_data["System date"] = '-'
            else
      
              # RFC 2579 - Textual Conventions for SMIv2
      Severity: Critical
      Found in modules/auxiliary/scanner/snmp/snmp_enum.rb - About 1 hr to fix

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

              fields_order = [
                "Host IP", "Hostname", "Description", "Contact",
                "Location", "Uptime snmp", "Uptime system",
                "System date", "domain", "User accounts",
                "Network information", "Network interfaces",
        Severity: Minor
        Found in modules/auxiliary/scanner/snmp/snmp_enum.rb and 5 other locations - About 15 mins to fix
        modules/auxiliary/scanner/http/file_same_name_dir.rb on lines 37..62
        modules/auxiliary/scanner/http/prev_dir_same_name_file.rb on lines 34..59
        modules/exploits/windows/iis/ms03_007_ntdll_webdav.rb on lines 137..163
        modules/post/windows/gather/enum_ms_product_keys.rb on lines 105..105
        scripts/meterpreter/winenum.rb on lines 59..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status