rapid7/metasploit-framework

View on GitHub
modules/exploits/linux/http/sonicwall_cve_2021_20039.rb

Summary

Maintainability
C
1 day
Test Coverage

Method check has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def check
    res = send_request_cgi({
      'uri' => normalize_uri(target_uri.path, '/cgi-bin/welcome'),
      'agent' => 'SonicWALL Mobile Connect'
    })
Severity: Minor
Found in modules/exploits/linux/http/sonicwall_cve_2021_20039.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'SonicWall SMA 100 Series Authenticated Command Injection',
Severity: Major
Found in modules/exploits/linux/http/sonicwall_cve_2021_20039.rb - About 2 hrs to fix

    Method check has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check
        res = send_request_cgi({
          'uri' => normalize_uri(target_uri.path, '/cgi-bin/welcome'),
          'agent' => 'SonicWALL Mobile Connect'
        })
    Severity: Minor
    Found in modules/exploits/linux/http/sonicwall_cve_2021_20039.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return CheckCode::Safe unless build.to_i <= 8 && point.to_i <= 37
      Severity: Major
      Found in modules/exploits/linux/http/sonicwall_cve_2021_20039.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return CheckCode::Safe
        Severity: Major
        Found in modules/exploits/linux/http/sonicwall_cve_2021_20039.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return CheckCode::Safe unless build.to_i <= 2 && point.to_i <= 24
          Severity: Major
          Found in modules/exploits/linux/http/sonicwall_cve_2021_20039.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return CheckCode::Safe
            Severity: Major
            Found in modules/exploits/linux/http/sonicwall_cve_2021_20039.rb - About 30 mins to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                  register_options([
                    OptString.new('TARGETURI', [true, 'Base path', '/']),
                    OptString.new('USERNAME', [true, 'The username to authenticate with', 'admin']),
                    OptString.new('PASSWORD', [true, 'The password to authenticate with', 'password']),
                    OptString.new('SWDOMAIN', [true, 'The domain to log in to', 'LocalDomain']),
              Severity: Major
              Found in modules/exploits/linux/http/sonicwall_cve_2021_20039.rb and 3 other locations - About 40 mins to fix
              modules/auxiliary/admin/http/openbravo_xxe.rb on lines 39..46
              modules/auxiliary/bnat/bnat_router.rb on lines 26..33
              modules/exploits/multi/http/dexter_casinoloader_exec.rb on lines 49..56

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 37.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status