Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/browser/adobe_jbig2decode.rb

Summary

Maintainability
C
1 day
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open


    xref = []
    eol = "\x0d\x0a"
    endobj = "endobj" << eol
Severity: Major
Found in modules/exploits/windows/browser/adobe_jbig2decode.rb and 1 other location - About 1 day to fix
modules/exploits/windows/fileformat/adobe_jbig2decode.rb on lines 176..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 333.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  def n_obfu(str)
    result = ""
    str.scan(/./u) do |c|
      if rand(3) == 0 and c.upcase >= 'A' and c.upcase <= 'Z'
        result << "#%x" % c.unpack("C*")[0]
Severity: Major
Found in modules/exploits/windows/browser/adobe_jbig2decode.rb and 1 other location - About 1 hr to fix
modules/exploits/windows/fileformat/adobe_jbig2decode.rb on lines 146..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 22 locations. Consider refactoring.
Open

    result = ""
    whitespace = ""
    str.each_byte do |b|
      result << whitespace << "%02x" % b
      whitespace = " " * (rand(3) + 1)
Severity: Major
Found in modules/exploits/windows/browser/adobe_jbig2decode.rb and 21 other locations - About 20 mins to fix
modules/exploits/multi/fileformat/adobe_u3d_meshcont.rb on lines 203..210
modules/exploits/windows/browser/adobe_cooltype_sing.rb on lines 377..384
modules/exploits/windows/browser/adobe_flashplayer_newfunction.rb on lines 272..279
modules/exploits/windows/browser/adobe_flatedecode_predictor02.rb on lines 145..152
modules/exploits/windows/browser/adobe_geticon.rb on lines 156..163
modules/exploits/windows/browser/adobe_media_newplayer.rb on lines 171..178
modules/exploits/windows/browser/adobe_toolbutton.rb on lines 205..212
modules/exploits/windows/browser/adobe_utilprintf.rb on lines 135..142
modules/exploits/windows/fileformat/adobe_collectemailinfo.rb on lines 129..136
modules/exploits/windows/fileformat/adobe_cooltype_sing.rb on lines 364..371
modules/exploits/windows/fileformat/adobe_flashplayer_button.rb on lines 278..285
modules/exploits/windows/fileformat/adobe_flashplayer_newfunction.rb on lines 274..281
modules/exploits/windows/fileformat/adobe_flatedecode_predictor02.rb on lines 141..148
modules/exploits/windows/fileformat/adobe_jbig2decode.rb on lines 166..173
modules/exploits/windows/fileformat/adobe_libtiff.rb on lines 134..141
modules/exploits/windows/fileformat/adobe_media_newplayer.rb on lines 173..180
modules/exploits/windows/fileformat/adobe_pdf_embedded_exe_nojs.rb on lines 113..120
modules/exploits/windows/fileformat/adobe_reader_u3d.rb on lines 515..522
modules/exploits/windows/fileformat/adobe_toolbutton.rb on lines 214..221
modules/exploits/windows/fileformat/adobe_u3d_meshdecl.rb on lines 281..288
modules/exploits/windows/fileformat/adobe_utilprintf.rb on lines 126..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status