rapid7/metasploit-framework

View on GitHub
modules/exploits/windows/fileformat/adobe_cooltype_sing.rb

Summary

Maintainability
F
6 days
Test Coverage

Method make_pdf has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def make_pdf(ttf, js)

    #swf_name = rand_text_alpha(8 + rand(8)) + ".swf"

    xref = []
Severity: Major
Found in modules/exploits/windows/fileformat/adobe_cooltype_sing.rb - About 5 hrs to fix

    File adobe_cooltype_sing.rb has 368 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'zlib'
    
    class MetasploitModule < Msf::Exploit::Remote
      Rank = GreatRanking # aslr+dep bypass, js heap spray, rop, stack bof
    
    
    Severity: Minor
    Found in modules/exploits/windows/fileformat/adobe_cooltype_sing.rb - About 4 hrs to fix

      Method make_js has 109 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def make_js(encoded_payload)
      
          # The following executes a ret2lib using icucnv36.dll
          # The effect is to bypass DEP and execute the shellcode in an indirect way
          stack_data = [
      Severity: Major
      Found in modules/exploits/windows/fileformat/adobe_cooltype_sing.rb - About 4 hrs to fix

        Method initialize has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(info = {})
            super(update_info(info,
              'Name'           => 'Adobe CoolType SING Table "uniqueName" Stack Buffer Overflow',
              'Description'    => %q{
                  This module exploits a vulnerability in the Smart INdependent Glyplets (SING) table
        Severity: Minor
        Found in modules/exploits/windows/fileformat/adobe_cooltype_sing.rb - About 1 hr to fix

          Method make_ttf has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def make_ttf
              ttf_data = ""
          
              # load the static ttf file
          
          
          Severity: Minor
          Found in modules/exploits/windows/fileformat/adobe_cooltype_sing.rb - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              def make_pdf(ttf, js)
            
                #swf_name = rand_text_alpha(8 + rand(8)) + ".swf"
            
                xref = []
            Severity: Major
            Found in modules/exploits/windows/fileformat/adobe_cooltype_sing.rb and 1 other location - About 2 days to fix
            modules/exploits/windows/browser/adobe_cooltype_sing.rb on lines 388..573

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 716.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              def make_js(encoded_payload)
            
                # The following executes a ret2lib using icucnv36.dll
                # The effect is to bypass DEP and execute the shellcode in an indirect way
                stack_data = [
            Severity: Major
            Found in modules/exploits/windows/fileformat/adobe_cooltype_sing.rb and 1 other location - About 7 hrs to fix
            modules/exploits/windows/browser/adobe_cooltype_sing.rb on lines 141..342

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 254.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 20 locations. Consider refactoring.
            Open

              def n_obfu(str)
                #return str
                result = ""
                str.scan(/./u) do |c|
                  if rand(2) == 0 and c.upcase >= 'A' and c.upcase <= 'Z'
            Severity: Major
            Found in modules/exploits/windows/fileformat/adobe_cooltype_sing.rb and 19 other locations - About 40 mins to fix
            modules/auxiliary/pdf/foxit/authbypass.rb on lines 50..59
            modules/exploits/multi/fileformat/adobe_u3d_meshcont.rb on lines 190..200
            modules/exploits/windows/browser/adobe_cooltype_sing.rb on lines 363..373
            modules/exploits/windows/browser/adobe_flashplayer_newfunction.rb on lines 259..268
            modules/exploits/windows/browser/adobe_flatedecode_predictor02.rb on lines 133..142
            modules/exploits/windows/browser/adobe_geticon.rb on lines 144..153
            modules/exploits/windows/browser/adobe_media_newplayer.rb on lines 159..168
            modules/exploits/windows/browser/adobe_toolbutton.rb on lines 191..201
            modules/exploits/windows/browser/adobe_utilprintf.rb on lines 123..132
            modules/exploits/windows/fileformat/adobe_collectemailinfo.rb on lines 117..126
            modules/exploits/windows/fileformat/adobe_flashplayer_button.rb on lines 265..274
            modules/exploits/windows/fileformat/adobe_flashplayer_newfunction.rb on lines 261..270
            modules/exploits/windows/fileformat/adobe_flatedecode_predictor02.rb on lines 128..137
            modules/exploits/windows/fileformat/adobe_libtiff.rb on lines 121..130
            modules/exploits/windows/fileformat/adobe_media_newplayer.rb on lines 160..169
            modules/exploits/windows/fileformat/adobe_pdf_embedded_exe_nojs.rb on lines 101..110
            modules/exploits/windows/fileformat/adobe_toolbutton.rb on lines 200..210
            modules/exploits/windows/fileformat/adobe_u3d_meshdecl.rb on lines 268..278
            modules/exploits/windows/fileformat/adobe_utilprintf.rb on lines 114..123

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 37.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 22 locations. Consider refactoring.
            Open

              def ascii_hex_whitespace_encode(str)
                result = ""
                whitespace = ""
                str.each_byte do |b|
                  result << whitespace << "%02x" % b
            Severity: Major
            Found in modules/exploits/windows/fileformat/adobe_cooltype_sing.rb and 21 other locations - About 20 mins to fix
            modules/exploits/multi/fileformat/adobe_u3d_meshcont.rb on lines 203..210
            modules/exploits/windows/browser/adobe_cooltype_sing.rb on lines 377..384
            modules/exploits/windows/browser/adobe_flashplayer_newfunction.rb on lines 272..279
            modules/exploits/windows/browser/adobe_flatedecode_predictor02.rb on lines 145..152
            modules/exploits/windows/browser/adobe_geticon.rb on lines 156..163
            modules/exploits/windows/browser/adobe_jbig2decode.rb on lines 175..182
            modules/exploits/windows/browser/adobe_media_newplayer.rb on lines 171..178
            modules/exploits/windows/browser/adobe_toolbutton.rb on lines 205..212
            modules/exploits/windows/browser/adobe_utilprintf.rb on lines 135..142
            modules/exploits/windows/fileformat/adobe_collectemailinfo.rb on lines 129..136
            modules/exploits/windows/fileformat/adobe_flashplayer_button.rb on lines 278..285
            modules/exploits/windows/fileformat/adobe_flashplayer_newfunction.rb on lines 274..281
            modules/exploits/windows/fileformat/adobe_flatedecode_predictor02.rb on lines 141..148
            modules/exploits/windows/fileformat/adobe_jbig2decode.rb on lines 166..173
            modules/exploits/windows/fileformat/adobe_libtiff.rb on lines 134..141
            modules/exploits/windows/fileformat/adobe_media_newplayer.rb on lines 173..180
            modules/exploits/windows/fileformat/adobe_pdf_embedded_exe_nojs.rb on lines 113..120
            modules/exploits/windows/fileformat/adobe_reader_u3d.rb on lines 515..522
            modules/exploits/windows/fileformat/adobe_toolbutton.rb on lines 214..221
            modules/exploits/windows/fileformat/adobe_u3d_meshdecl.rb on lines 281..288
            modules/exploits/windows/fileformat/adobe_utilprintf.rb on lines 126..133

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 28.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status