Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/exploits/windows/fileformat/adobe_toolbutton.rb

Summary

Maintainability
D
2 days
Test Coverage

Method make_js has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def make_js

    # CreateFileMappingA + MapViewOfFile + memcpy rop chain
    rop_9 = Rex::Text.to_unescape(generate_rop_payload('reader', '', { 'target' => '9' }))
    rop_10 = Rex::Text.to_unescape(generate_rop_payload('reader', '', { 'target' => '10' }))
Severity: Major
Found in modules/exploits/windows/fileformat/adobe_toolbutton.rb - About 3 hrs to fix

    Method make_pdf has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def make_pdf(js)
    xref = []
    eol = "\n"
    endobj = "endobj" << eol
    Severity: Major
    Found in modules/exploits/windows/fileformat/adobe_toolbutton.rb - About 2 hrs to fix

      File adobe_toolbutton.rb has 261 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class MetasploitModule < Msf::Exploit::Remote
  Rank = NormalRanking

  include Msf::Exploit::FILEFORMAT
  include Msf::Exploit::RopDb
      Severity: Minor
      Found in modules/exploits/windows/fileformat/adobe_toolbutton.rb - About 2 hrs to fix

        Method initialize has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Adobe Reader ToolButton Use After Free',
      'Description'    => %q{
        This module exploits a use after free condition on Adobe Reader versions 11.0.2, 10.1.6
        Severity: Minor
        Found in modules/exploits/windows/fileformat/adobe_toolbutton.rb - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def make_pdf(js)
    xref = []
    eol = "\n"
    endobj = "endobj" << eol
          Severity: Major
          Found in modules/exploits/windows/fileformat/adobe_toolbutton.rb and 1 other location - About 1 day to fix
          modules/exploits/windows/browser/adobe_toolbutton.rb on lines 216..320

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 357.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 20 locations. Consider refactoring.
          Open

            def n_obfu(str)
    #return str
    result = ""
    str.scan(/./u) do |c|
      if rand(2) == 0 and c.upcase >= 'A' and c.upcase <= 'Z'
          Severity: Major
          Found in modules/exploits/windows/fileformat/adobe_toolbutton.rb and 19 other locations - About 40 mins to fix
          modules/auxiliary/pdf/foxit/authbypass.rb on lines 50..59
          modules/exploits/multi/fileformat/adobe_u3d_meshcont.rb on lines 190..200
          modules/exploits/windows/browser/adobe_cooltype_sing.rb on lines 363..373
          modules/exploits/windows/browser/adobe_flashplayer_newfunction.rb on lines 259..268
          modules/exploits/windows/browser/adobe_flatedecode_predictor02.rb on lines 133..142
          modules/exploits/windows/browser/adobe_geticon.rb on lines 144..153
          modules/exploits/windows/browser/adobe_media_newplayer.rb on lines 159..168
          modules/exploits/windows/browser/adobe_toolbutton.rb on lines 191..201
          modules/exploits/windows/browser/adobe_utilprintf.rb on lines 123..132
          modules/exploits/windows/fileformat/adobe_collectemailinfo.rb on lines 117..126
          modules/exploits/windows/fileformat/adobe_cooltype_sing.rb on lines 350..360
          modules/exploits/windows/fileformat/adobe_flashplayer_button.rb on lines 265..274
          modules/exploits/windows/fileformat/adobe_flashplayer_newfunction.rb on lines 261..270
          modules/exploits/windows/fileformat/adobe_flatedecode_predictor02.rb on lines 128..137
          modules/exploits/windows/fileformat/adobe_libtiff.rb on lines 121..130
          modules/exploits/windows/fileformat/adobe_media_newplayer.rb on lines 160..169
          modules/exploits/windows/fileformat/adobe_pdf_embedded_exe_nojs.rb on lines 101..110
          modules/exploits/windows/fileformat/adobe_u3d_meshdecl.rb on lines 268..278
          modules/exploits/windows/fileformat/adobe_utilprintf.rb on lines 114..123

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 37.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 22 locations. Consider refactoring.
          Open

            def ascii_hex_whitespace_encode(str)
    result = ""
    whitespace = ""
    str.each_byte do |b|
      result << whitespace << "%02x" % b
          Severity: Major
          Found in modules/exploits/windows/fileformat/adobe_toolbutton.rb and 21 other locations - About 20 mins to fix
          modules/exploits/multi/fileformat/adobe_u3d_meshcont.rb on lines 203..210
          modules/exploits/windows/browser/adobe_cooltype_sing.rb on lines 377..384
          modules/exploits/windows/browser/adobe_flashplayer_newfunction.rb on lines 272..279
          modules/exploits/windows/browser/adobe_flatedecode_predictor02.rb on lines 145..152
          modules/exploits/windows/browser/adobe_geticon.rb on lines 156..163
          modules/exploits/windows/browser/adobe_jbig2decode.rb on lines 175..182
          modules/exploits/windows/browser/adobe_media_newplayer.rb on lines 171..178
          modules/exploits/windows/browser/adobe_toolbutton.rb on lines 205..212
          modules/exploits/windows/browser/adobe_utilprintf.rb on lines 135..142
          modules/exploits/windows/fileformat/adobe_collectemailinfo.rb on lines 129..136
          modules/exploits/windows/fileformat/adobe_cooltype_sing.rb on lines 364..371
          modules/exploits/windows/fileformat/adobe_flashplayer_button.rb on lines 278..285
          modules/exploits/windows/fileformat/adobe_flashplayer_newfunction.rb on lines 274..281
          modules/exploits/windows/fileformat/adobe_flatedecode_predictor02.rb on lines 141..148
          modules/exploits/windows/fileformat/adobe_jbig2decode.rb on lines 166..173
          modules/exploits/windows/fileformat/adobe_libtiff.rb on lines 134..141
          modules/exploits/windows/fileformat/adobe_media_newplayer.rb on lines 173..180
          modules/exploits/windows/fileformat/adobe_pdf_embedded_exe_nojs.rb on lines 113..120
          modules/exploits/windows/fileformat/adobe_reader_u3d.rb on lines 515..522
          modules/exploits/windows/fileformat/adobe_u3d_meshdecl.rb on lines 281..288
          modules/exploits/windows/fileformat/adobe_utilprintf.rb on lines 126..133

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 28.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status