Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/payloads/singles/windows/download_exec.rb

Summary

Maintainability
D
2 days
Test Coverage

Method generate has 285 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def generate(_opts = {})

    target_uri = datastore['URL'] || ""
    filename = datastore['EXE'] || ""
    proto = "https"
Severity: Major
Found in modules/payloads/singles/windows/download_exec.rb - About 1 day to fix

    File download_exec.rb has 310 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module MetasploitModule

  CachedSize = 423

  include Msf::Payload::Windows
    Severity: Minor
    Found in modules/payloads/singles/windows/download_exec.rb - About 3 hrs to fix

      Method generate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def generate(_opts = {})

    target_uri = datastore['URL'] || ""
    filename = datastore['EXE'] || ""
    proto = "https"
      Severity: Minor
      Found in modules/payloads/singles/windows/download_exec.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status