rapid7/metasploit-framework

View on GitHub
modules/post/multi/sap/smdagent_get_properties.rb

Summary

Maintainability
F
3 days
Test Coverage

Method run has a Cognitive Complexity of 110 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    case session.type
    when 'meterpreter'
      meterpreter = true
    else
Severity: Minor
Found in modules/post/multi/sap/smdagent_get_properties.rb - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 150 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    case session.type
    when 'meterpreter'
      meterpreter = true
    else
Severity: Major
Found in modules/post/multi/sap/smdagent_get_properties.rb - About 6 hrs to fix

    Method initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
        super(
          update_info(
            info,
            'Name' => 'Diagnostics Agent in Solution Manager, stores unencrypted credentials for Solution Manager server',
    Severity: Minor
    Found in modules/post/multi/sap/smdagent_get_properties.rb - About 1 hr to fix

      Method parse_properties_file has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def parse_properties_file(filename, is_meterpreter)
          properties = []
          if file_exist?(filename)
            properties_content = read_file(filename)
            if properties_content.nil?
      Severity: Minor
      Found in modules/post/multi/sap/smdagent_get_properties.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                    rescue Rex::Post::Meterpreter::RequestError
                      print_error("Failed to resolve SLD hostname: #{sld_hostname}")
      Severity: Major
      Found in modules/post/multi/sap/smdagent_get_properties.rb - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status