Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/gather/credentials/safari.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method initialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Safari credential gatherer',
Severity: Minor
Found in modules/post/windows/gather/credentials/safari.rb - About 1 hr to fix

    Similar blocks of code found in 28 locations. Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Safari credential gatherer',
    Severity: Major
    Found in modules/post/windows/gather/credentials/safari.rb and 27 other locations - About 2 hrs to fix
    modules/post/windows/gather/credentials/aim.rb on lines 73..112
    modules/post/windows/gather/credentials/chrome.rb on lines 86..125
    modules/post/windows/gather/credentials/comodo.rb on lines 121..160
    modules/post/windows/gather/credentials/coolnovo.rb on lines 51..90
    modules/post/windows/gather/credentials/digsby.rb on lines 46..85
    modules/post/windows/gather/credentials/flock.rb on lines 68..107
    modules/post/windows/gather/credentials/gadugadu.rb on lines 48..87
    modules/post/windows/gather/credentials/icq.rb on lines 73..112
    modules/post/windows/gather/credentials/ie.rb on lines 29..68
    modules/post/windows/gather/credentials/incredimail.rb on lines 47..86
    modules/post/windows/gather/credentials/kakaotalk.rb on lines 44..79
    modules/post/windows/gather/credentials/kmeleon.rb on lines 104..139
    modules/post/windows/gather/credentials/line.rb on lines 77..112
    modules/post/windows/gather/credentials/maxthon.rb on lines 47..82
    modules/post/windows/gather/credentials/miranda.rb on lines 47..82
    modules/post/windows/gather/credentials/opera.rb on lines 97..132
    modules/post/windows/gather/credentials/operamail.rb on lines 72..107
    modules/post/windows/gather/credentials/postbox.rb on lines 306..341
    modules/post/windows/gather/credentials/qq.rb on lines 29..64
    modules/post/windows/gather/credentials/seamonkey.rb on lines 112..147
    modules/post/windows/gather/credentials/srware.rb on lines 81..116
    modules/post/windows/gather/credentials/tango.rb on lines 75..110
    modules/post/windows/gather/credentials/thunderbird.rb on lines 186..221
    modules/post/windows/gather/credentials/tlen.rb on lines 54..89
    modules/post/windows/gather/credentials/viber.rb on lines 45..80
    modules/post/windows/gather/credentials/windowslivemail.rb on lines 47..82
    modules/post/windows/gather/credentials/xchat.rb on lines 47..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 77.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 28 locations. Consider refactoring.
    Open

      def run
    print_status('Filtering based on these selections:  ')
    print_status("ARTIFACTS: #{datastore['ARTIFACTS'].capitalize}")
    print_status("STORE_LOOT: #{datastore['STORE_LOOT']}")
    print_status("EXTRACT_DATA: #{datastore['EXTRACT_DATA']}\n")
    Severity: Major
    Found in modules/post/windows/gather/credentials/safari.rb and 27 other locations - About 30 mins to fix
    modules/post/windows/gather/credentials/aim.rb on lines 116..127
    modules/post/windows/gather/credentials/chrome.rb on lines 129..140
    modules/post/windows/gather/credentials/comodo.rb on lines 164..175
    modules/post/windows/gather/credentials/coolnovo.rb on lines 94..105
    modules/post/windows/gather/credentials/digsby.rb on lines 89..100
    modules/post/windows/gather/credentials/flock.rb on lines 111..122
    modules/post/windows/gather/credentials/gadugadu.rb on lines 91..102
    modules/post/windows/gather/credentials/icq.rb on lines 116..127
    modules/post/windows/gather/credentials/ie.rb on lines 72..83
    modules/post/windows/gather/credentials/incredimail.rb on lines 90..101
    modules/post/windows/gather/credentials/kakaotalk.rb on lines 83..94
    modules/post/windows/gather/credentials/kmeleon.rb on lines 143..154
    modules/post/windows/gather/credentials/line.rb on lines 116..127
    modules/post/windows/gather/credentials/maxthon.rb on lines 86..97
    modules/post/windows/gather/credentials/opera.rb on lines 136..147
    modules/post/windows/gather/credentials/operamail.rb on lines 111..122
    modules/post/windows/gather/credentials/postbox.rb on lines 345..356
    modules/post/windows/gather/credentials/qq.rb on lines 68..79
    modules/post/windows/gather/credentials/redis_desktop_manager.rb on lines 80..91
    modules/post/windows/gather/credentials/seamonkey.rb on lines 151..162
    modules/post/windows/gather/credentials/srware.rb on lines 120..131
    modules/post/windows/gather/credentials/tango.rb on lines 114..125
    modules/post/windows/gather/credentials/thunderbird.rb on lines 225..236
    modules/post/windows/gather/credentials/tlen.rb on lines 93..104
    modules/post/windows/gather/credentials/viber.rb on lines 84..95
    modules/post/windows/gather/credentials/windowslivemail.rb on lines 86..97
    modules/post/windows/gather/credentials/xchat.rb on lines 86..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status