Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/manage/enable_rdp.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method run has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    if datastore['ENABLE'] || (datastore['USERNAME'] && datastore['PASSWORD'])
      cleanup_rc = store_loot(
        'host.windows.cleanup.enable_rdp',
        'text/plain',
Severity: Minor
Found in modules/post/windows/manage/enable_rdp.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addrdpusr has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def addrdpusr(username, password, cleanup_rc)
    print_status 'Setting user account for logon'
    print_status "\tAdding User: #{username} with Password: #{password}"
    begin
      if check_user(username)
Severity: Minor
Found in modules/post/windows/manage/enable_rdp.rb - About 1 hr to fix

    Method addrdpusr has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def addrdpusr(username, password, cleanup_rc)
    print_status 'Setting user account for logon'
    print_status "\tAdding User: #{username} with Password: #{password}"
    begin
      if check_user(username)
    Severity: Minor
    Found in modules/post/windows/manage/enable_rdp.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    if datastore['ENABLE'] || (datastore['USERNAME'] && datastore['PASSWORD'])
      cleanup_rc = store_loot(
        'host.windows.cleanup.enable_rdp',
        'text/plain',
    Severity: Minor
    Found in modules/post/windows/manage/enable_rdp.rb - About 1 hr to fix

      Method enabletssrv has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def enabletssrv(cleanup_rc)
    service_name = 'termservice'
    srv_info = service_info(service_name)
    begin
      print_status 'Setting Terminal Services service startup mode'
      Severity: Minor
      Found in modules/post/windows/manage/enable_rdp.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status