Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/post/windows/manage/mssql_local_auth_bypass.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Windows Manage Local Microsoft SQL Server Authorization Bypass',
Severity: Minor
Found in modules/post/windows/manage/mssql_local_auth_bypass.rb - About 1 hr to fix

    Method remove_login has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def remove_login(service, instance_name)
    remove_status = remove_sql_login(datastore['DB_USERNAME'], instance_name)

    unless remove_status
      raise 'Retry'
    Severity: Minor
    Found in modules/post/windows/manage/mssql_local_auth_bypass.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_login has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def add_login(service, instance_name)
    add_login_status = add_sql_login(datastore['DB_USERNAME'],
                                     datastore['DB_PASSWORD'],
                                     instance_name)
    Severity: Minor
    Found in modules/post/windows/manage/mssql_local_auth_bypass.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
    # Set instance name (if specified)
    instance = datastore['INSTANCE'].to_s

    # Display target
    Severity: Minor
    Found in modules/post/windows/manage/mssql_local_auth_bypass.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status