rapid7/metasploit-framework

View on GitHub
scripts/meterpreter/enum_firefox.rb

Summary

Maintainability
C
1 day
Test Coverage

Method frfxdmp has 122 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def frfxdmp(usrnm)
  sitesvisited = []
  dnldsmade = []
  bkmrks = []
  cookies = []
Severity: Major
Found in scripts/meterpreter/enum_firefox.rb - About 4 hrs to fix

    Method frfxdmp has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def frfxdmp(usrnm)
      sitesvisited = []
      dnldsmade = []
      bkmrks = []
      cookies = []
    Severity: Minor
    Found in scripts/meterpreter/enum_firefox.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method frfxpswd has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def frfxpswd(path,usrnm)
      @client.fs.dir.foreach(path) {|x|
        next if x =~ /^(\.|\.\.)$/
        fullpath = path + '\\' + x
    
    
    Severity: Minor
    Found in scripts/meterpreter/enum_firefox.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

              if kill_frfx
                kill_firefox
              end
    Severity: Major
    Found in scripts/meterpreter/enum_firefox.rb - About 45 mins to fix

      Method frfxpilfer has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def frfxpilfer(frfoxdbloc,session,logs,usrnm,logfile)
      Severity: Minor
      Found in scripts/meterpreter/enum_firefox.rb - About 35 mins to fix

        Method frfxplacesget has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def frfxplacesget(path,usrnm)
          # Create the log
          ::FileUtils.mkdir_p(@logs)
          @client.fs.dir.foreach(path) {|x|
            next if x =~ /^(\.|\.\.)$/
        Severity: Minor
        Found in scripts/meterpreter/enum_firefox.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          begin
            print_status("\tGetting Firefox Form History for #{usrnm}")
            db = SQLite3::Database.new(formdb)
            #print_status("\tProcessing #{formdb}")
            db.execute("SELECT fieldname,value FROM moz_formhistory") do |row|
        Severity: Major
        Found in scripts/meterpreter/enum_firefox.rb and 1 other location - About 1 hr to fix
        scripts/meterpreter/enum_firefox.rb on lines 149..165

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          begin
            print_status("\tGetting Firefox Search History for #{usrnm}")
            db = SQLite3::Database.new(searchdb)
            #print_status("\tProcessing #{searchdb}")
            db.execute("SELECT name,value FROM engine_data") do |row|
        Severity: Major
        Found in scripts/meterpreter/enum_firefox.rb and 1 other location - About 1 hr to fix
        scripts/meterpreter/enum_firefox.rb on lines 131..147

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status