rapid7/metasploit-framework

View on GitHub
scripts/meterpreter/enum_powershell_env.rb

Summary

Maintainability
C
1 day
Test Coverage

Method enum_powershell has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

def enum_powershell
  #Check if PowerShell is Installed
  if registry_enumkeys("HKLM\\SOFTWARE\\Microsoft\\").include?("PowerShell")
    print_status("Powershell is Installed on this system.")
    powershell_version = registry_getvaldata("HKLM\\SOFTWARE\\Microsoft\\PowerShell\\1\\PowerShellEngine","PowerShellVersion")
Severity: Minor
Found in scripts/meterpreter/enum_powershell_env.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enum_powershell has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def enum_powershell
  #Check if PowerShell is Installed
  if registry_enumkeys("HKLM\\SOFTWARE\\Microsoft\\").include?("PowerShell")
    print_status("Powershell is Installed on this system.")
    powershell_version = registry_getvaldata("HKLM\\SOFTWARE\\Microsoft\\PowerShell\\1\\PowerShellEngine","PowerShellVersion")
Severity: Major
Found in scripts/meterpreter/enum_powershell_env.rb - About 2 hrs to fix

    Method enum_users has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def enum_users
      os = @client.sys.config.sysinfo['OS']
      users = []
      user = @client.sys.config.getuid
      path4users = ""
    Severity: Minor
    Found in scripts/meterpreter/enum_powershell_env.rb - About 1 hr to fix

      Method enum_users has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def enum_users
        os = @client.sys.config.sysinfo['OS']
        users = []
        user = @client.sys.config.getuid
        path4users = ""
      Severity: Minor
      Found in scripts/meterpreter/enum_powershell_env.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              next if p =~ /^(\.|\.\.)$/
              if p =~ /Microsoft.PowerShell_profile.ps1/
                ps_profile = session.fs.file.new("#{u["userappdata"]}Microsoft.PowerShell_profile.ps1", "rb")
                until ps_profile.eof?
                  tmpout << ps_profile.read
      Severity: Major
      Found in scripts/meterpreter/enum_powershell_env.rb and 1 other location - About 1 hr to fix
      modules/post/windows/gather/enum_powershell_env.rb on lines 116..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if registry_enumkeys("HKLM\\SOFTWARE\\Microsoft\\PowerShell\\1").include?("PowerShellSnapIns")
            print_status("Powershell Snap-Ins:")
            registry_enumkeys("HKLM\\SOFTWARE\\Microsoft\\PowerShell\\1\\PowerShellSnapIns").each do |si|
              print_status("\tSnap-In: #{si}")
              registry_enumvals("HKLM\\SOFTWARE\\Microsoft\\PowerShell\\1\\PowerShellSnapIns\\#{si}").each do |v|
      Severity: Minor
      Found in scripts/meterpreter/enum_powershell_env.rb and 1 other location - About 40 mins to fix
      modules/post/windows/gather/enum_powershell_env.rb on lines 89..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status