Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
scripts/meterpreter/enum_vmware.rb

Summary

Maintainability
C
1 day
Test Coverage

Method enum_viclient has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

def enum_viclient
  print_status("Information about VMware VI Client:")
  vi_pluggins = nil
  begin
    vi_version = registry_getvaldata("HKLM\\SOFTWARE\\VMware, Inc.\\VMware Virtual Infrastructure Client\\4.0","InstalledVersion")
Severity: Minor
Found in scripts/meterpreter/enum_vmware.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File enum_vmware.rb has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

@client = client

opts = Rex::Parser::Arguments.new(
  "-h" => [ false,"Help menu." ]
)
Severity: Minor
Found in scripts/meterpreter/enum_vmware.rb - About 2 hrs to fix

    Method enum_viclient has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def enum_viclient
  print_status("Information about VMware VI Client:")
  vi_pluggins = nil
  begin
    vi_version = registry_getvaldata("HKLM\\SOFTWARE\\VMware, Inc.\\VMware Virtual Infrastructure Client\\4.0","InstalledVersion")
    Severity: Major
    Found in scripts/meterpreter/enum_vmware.rb - About 2 hrs to fix

      Method enum_vum has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      def enum_vum
  print_status("Information about VMware Update Manager:")
  begin
    vum_version = registry_getvaldata("HKLM\\SOFTWARE\\VMware, Inc.\\VMware Update Manager","InstalledVersion")
    vum_server = registry_getvaldata("HKLM\\SOFTWARE\\VMware, Inc.\\VMware Update Manager","VUMServer")
      Severity: Minor
      Found in scripts/meterpreter/enum_vmware.rb - About 1 hr to fix

        Method enum_users has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        def enum_users
  os = @client.sys.config.sysinfo['OS']
  users = []
  path4users = ""
  sysdrv = @client.sys.config.getenv('SystemDrive')
        Severity: Minor
        Found in scripts/meterpreter/enum_vmware.rb - About 1 hr to fix

          Method enum_users has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def enum_users
  os = @client.sys.config.sysinfo['OS']
  users = []
  path4users = ""
  sysdrv = @client.sys.config.getenv('SystemDrive')
          Severity: Minor
          Found in scripts/meterpreter/enum_vmware.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method enum_vmwarewrk has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def enum_vmwarewrk
  config = ""
  name = ""
  print_status("Enumerating VMware Workstation VM's:")
  fav_file = ""
          Severity: Minor
          Found in scripts/meterpreter/enum_vmware.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method enum_vihosupdt has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def enum_vihosupdt
  hosts = []
  print_status("Information about VMware vSphere Host Update Utility:")
  enum_users.each do |u|
    print_status("\tESX/ESXi Hosts added for Updates for user #{u['username']}:")
          Severity: Minor
          Found in scripts/meterpreter/enum_vmware.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              print_status("Running as SYSTEM extracting user list..")
    @client.fs.dir.foreach(path4users) do |u|
      userinfo = {}
      next if u =~ /^(\.|\.\.|All Users|Default|Default User|Public|desktop.ini|LocalService|NetworkService)$/
      userinfo['username'] = u
          Severity: Minor
          Found in scripts/meterpreter/enum_vmware.rb and 1 other location - About 30 mins to fix
          scripts/meterpreter/get_filezilla_creds.rb on lines 134..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status