rapid7/metasploit-framework

View on GitHub
scripts/meterpreter/event_manager.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method list_logs has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def list_logs(eventlog_name,filter,filter_string,logs,local_log,sup_print)
  begin
    event_data = ""
    csv_data = "EventID,Date,Data\n"
    log = @client.sys.eventlog.open(eventlog_name)
Severity: Minor
Found in scripts/meterpreter/event_manager.rb - About 1 hr to fix

    Method list_logs has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def list_logs(eventlog_name,filter,filter_string,logs,local_log,sup_print)
    Severity: Minor
    Found in scripts/meterpreter/event_manager.rb - About 45 mins to fix

      Method get_log_details has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_log_details
        logs_detail = Array.new
      
        eventlog_list.each do |log_name|
      
      
      Severity: Minor
      Found in scripts/meterpreter/event_manager.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method list_logs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def list_logs(eventlog_name,filter,filter_string,logs,local_log,sup_print)
        begin
          event_data = ""
          csv_data = "EventID,Date,Data\n"
          log = @client.sys.eventlog.open(eventlog_name)
      Severity: Minor
      Found in scripts/meterpreter/event_manager.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status