Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
scripts/meterpreter/get_application_list.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method app_list has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

def app_list
  tbl = Rex::Text::Table.new(
    'Header'  => "Installed Applications",
    'Indent'  => 1,
    'Columns' => [
Severity: Minor
Found in scripts/meterpreter/get_application_list.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method app_list has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def app_list
  tbl = Rex::Text::Table.new(
    'Header'  => "Installed Applications",
    'Indent'  => 1,
    'Columns' => [
Severity: Minor
Found in scripts/meterpreter/get_application_list.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status