Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
scripts/meterpreter/getcountermeasure.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File getcountermeasure.rb has 352 lines of code (exceeds 250 allowed). Consider refactoring.
Open

session = client
@@exec_opts = Rex::Parser::Arguments.new(
  "-h" => [ false, "Help menu." ],
  "-k" => [ false, "Kill any AV, HIPS and Third Party Firewall process found." ],
  "-d" => [ false, "Disable built in Firewall" ]
Severity: Minor
Found in scripts/meterpreter/getcountermeasure.rb - About 4 hrs to fix

    Method checkdep has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def checkdep(session)
  tmpout = ""
  depmode = ""
  # Expand environment %TEMP% variable
  tmp = session.sys.config.getenv('TEMP')
    Severity: Minor
    Found in scripts/meterpreter/getcountermeasure.rb - About 1 hr to fix

      Method checklocalfw has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def checklocalfw(session,killfw)
  print_status("Getting Windows Built in Firewall configuration...")
  opmode = ""
  r = session.sys.process.execute("cmd.exe /c netsh firewall show opmode", nil, {'Hidden' => 'true', 'Channelized' => true})
  while(d = r.channel.read)
      Severity: Minor
      Found in scripts/meterpreter/getcountermeasure.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status