rapid7/metasploit-framework

View on GitHub
scripts/meterpreter/getgui.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method addrdpusr has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def addrdpusr(session, username, password)

  rdu = resolve_sid("S-1-5-32-555")[:name]
  admin = resolve_sid("S-1-5-32-544")[:name]

Severity: Minor
Found in scripts/meterpreter/getgui.rb - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

            if is_admin?
              enablerd()
              enabletssrv()
            else
              print_error("Insufficient privileges, Remote Desktop Service was not modified.")
    Severity: Major
    Found in scripts/meterpreter/getgui.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

              if is_admin?
                addrdpusr(session, usr, pass)
              else
                print_error("Insufficient privileges, account was not be created.")
              end
      Severity: Major
      Found in scripts/meterpreter/getgui.rb - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        @@exec_opts = Rex::Parser::Arguments.new(
          "-h" => [ false, "Help menu." ],
          "-e" => [ false, "Enable RDP only." ],
          "-p" => [ true,  "The Password of the user to add." ],
          "-u" => [ true,  "The Username of the user to add." ],
        Severity: Minor
        Found in scripts/meterpreter/getgui.rb and 1 other location - About 15 mins to fix
        scripts/meterpreter/gettelnet.rb on lines 25..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status