rapid7/metasploit-framework

View on GitHub
scripts/meterpreter/hashdump.rb

Summary

Maintainability
C
1 day
Test Coverage

Method decrypt_user_keys has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def decrypt_user_keys(hbootkey, users)
  users.each_key do |rid|
    user = users[rid]

    hashlm_enc = ""
Severity: Minor
Found in scripts/meterpreter/hashdump.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method capture_user_keys has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def capture_user_keys
  users = {}
  ok = @client.sys.registry.open_key(HKEY_LOCAL_MACHINE, "SAM\\SAM\\Domains\\Account\\Users", KEY_READ)
  return if not ok

Severity: Minor
Found in scripts/meterpreter/hashdump.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method capture_user_keys has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def capture_user_keys
  users = {}
  ok = @client.sys.registry.open_key(HKEY_LOCAL_MACHINE, "SAM\\SAM\\Domains\\Account\\Users", KEY_READ)
  return if not ok

Severity: Minor
Found in scripts/meterpreter/hashdump.rb - About 1 hr to fix

    Method decrypt_user_hash has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def decrypt_user_hash(rid, hbootkey, enchash, pass)
    
      if(enchash.empty?)
        case pass
        when @sam_lmpass
    Severity: Minor
    Found in scripts/meterpreter/hashdump.rb - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          users.keys.sort{|a,b| a<=>b}.each do |rid|
            #If we have a hint then print it
            if !users[rid][:UserPasswordHint].nil? && users[rid][:UserPasswordHint].length > 0
              print_line "#{users[rid][:Name]}:\"#{users[rid][:UserPasswordHint]}\""
              hint_count += 1
      Severity: Major
      Found in scripts/meterpreter/hashdump.rb and 1 other location - About 1 hr to fix
      modules/post/windows/gather/hashdump.rb on lines 59..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

      def rid_to_key(rid)
      
        s1 = [rid].pack("V")
        s1 << s1[0,3]
      
      
      Severity: Major
      Found in scripts/meterpreter/hashdump.rb and 4 other locations - About 1 hr to fix
      lib/msf/util/windows_crypto_helpers.rb on lines 122..131
      modules/post/windows/gather/hashdump.rb on lines 248..256
      modules/post/windows/gather/smart_hashdump.rb on lines 176..184
      modules/post/windows/manage/hashcarve.rb on lines 159..165

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            hashstring = "#{users[rid][:Name]}:#{rid}:#{users[rid][:hashlm].unpack("H*")[0]}:#{users[rid][:hashnt].unpack("H*")[0]}:::"
      Severity: Minor
      Found in scripts/meterpreter/hashdump.rb and 1 other location - About 35 mins to fix
      modules/post/windows/gather/hashdump.rb on lines 94..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

      def decode_windows_hint(e_string)
        d_string = ""
        e_string.scan(/..../).each do |chunk|
          bytes = chunk.scan(/../)
          d_string += (bytes[1] + bytes[0]).to_s.hex.chr
      Severity: Minor
      Found in scripts/meterpreter/hashdump.rb and 2 other locations - About 25 mins to fix
      modules/post/windows/gather/hashdump.rb on lines 239..245
      modules/post/windows/gather/smart_hashdump.rb on lines 166..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status