Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
scripts/meterpreter/packetrecorder.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method packetrecord has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

def packetrecord(packtime, logfile,intid)
  begin
    rec = 1
    print_status("Packets being saved in to #{logfile}")
    print_status("Packet capture interval is #{packtime} Seconds")
Severity: Minor
Found in scripts/meterpreter/packetrecorder.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method packetrecord has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def packetrecord(packtime, logfile,intid)
  begin
    rec = 1
    print_status("Packets being saved in to #{logfile}")
    print_status("Packet capture interval is #{packtime} Seconds")
Severity: Major
Found in scripts/meterpreter/packetrecorder.rb - About 2 hrs to fix

    There are no issues that match your filters.

    Category
    Status