Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
scripts/meterpreter/winbf.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method passbf has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

def passbf(session,passlist,target,user,opt,logfile)
  print_status("Running Brute force attack against #{user}")
  print_status("Successful Username and Password pairs are being saved in #{logfile}")
  result = []
  output = []
Severity: Minor
Found in scripts/meterpreter/winbf.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method passbf has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def passbf(session,passlist,target,user,opt,logfile)
  print_status("Running Brute force attack against #{user}")
  print_status("Successful Username and Password pairs are being saved in #{logfile}")
  result = []
  output = []
Severity: Minor
Found in scripts/meterpreter/winbf.rb - About 1 hr to fix

    Method chkpolicy has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def chkpolicy(session)
  print_status("Checking password policy...")
  output = []
  begin
    r = session.sys.process.execute("net accounts", nil, {'Hidden' => true, 'Channelized' => true})
    Severity: Minor
    Found in scripts/meterpreter/winbf.rb - About 1 hr to fix

      Method passbf has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def passbf(session,passlist,target,user,opt,logfile)
      Severity: Minor
      Found in scripts/meterpreter/winbf.rb - About 45 mins to fix

        Method chkpolicy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        def chkpolicy(session)
  print_status("Checking password policy...")
  output = []
  begin
    r = session.sys.process.execute("net accounts", nil, {'Hidden' => true, 'Channelized' => true})
        Severity: Minor
        Found in scripts/meterpreter/winbf.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status