redux-form/redux-form

View on GitHub

Showing 125 of 125 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    extendWith<T: Object, A: Object, B: Object>(
      object: T,
      s1: A,
      s2: B,
      customizer?: (
Severity: Major
Found in flow-typed/npm/lodash_v4.x.x.js and 3 other locations - About 30 mins to fix
flow-typed/npm/lodash_v4.x.x.js on lines 989..1000
flow-typed/npm/lodash_v4.x.x.js on lines 1040..1051
flow-typed/npm/lodash_v4.x.x.js on lines 1211..1222

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

      return copy
Severity: Major
Found in src/structure/plain/deleteIn.js - About 30 mins to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        assignInWith<T: Object, A: Object, B: Object>(
          object: T,
          s1: A,
          s2: B,
          customizer?: (
    Severity: Major
    Found in flow-typed/npm/lodash_v4.x.x.js and 3 other locations - About 30 mins to fix
    flow-typed/npm/lodash_v4.x.x.js on lines 1040..1051
    flow-typed/npm/lodash_v4.x.x.js on lines 1107..1118
    flow-typed/npm/lodash_v4.x.x.js on lines 1211..1222

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

      return event
    Severity: Major
    Found in src/events/getValue.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        if (React.isValidElement(obj) || React.isValidElement(other)) return false
      Severity: Major
      Found in src/structure/plain/deepEqual.js - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language