refinery29/php-cs-fixer-config

View on GitHub

Showing 5 of 5 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/*
 * Copyright (c) 2016 Refinery29, Inc.
 *
Severity: Major
Found in src/Php70.php and 1 other location - About 1 wk to fix
src/Php56.php on lines 1..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1088.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/*
 * Copyright (c) 2016 Refinery29, Inc.
 *
Severity: Major
Found in src/Php56.php and 1 other location - About 1 wk to fix
src/Php70.php on lines 1..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 1088.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method getRules has 156 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getRules()
    {
        $rules = [
            '@PSR2' => true,
            'array_syntax' => [
Severity: Major
Found in src/Php71.php - About 6 hrs to fix

    Method getRules has 149 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getRules()
        {
            $rules = [
                '@PSR2' => true,
                'array_syntax' => [
    Severity: Major
    Found in src/Php56.php - About 5 hrs to fix

      Method getRules has 149 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getRules()
          {
              $rules = [
                  '@PSR2' => true,
                  'array_syntax' => [
      Severity: Major
      Found in src/Php70.php - About 5 hrs to fix
        Severity
        Category
        Status
        Source
        Language