reharik/papers-lti

View on GitHub

Showing 4 of 4 total issues

Function strategy has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const strategy = function(validate, options) {

  // If it's intended to check tool consumer's identity from database
  // Dev will pass a function that handle it
  // This will get called when the request authenticates
Severity: Minor
Found in lib/strategy.js - About 1 hr to fix

    Function authenticate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const authenticate = function (_req) {
        // to accomidate koa
        let req = _req.request || _req;
        if (req.body.lti_message_type !== 'basic-lti-launch-request') {
          return {type: 'fail', details: {error: `Request isn't LTI launch`}};
    Severity: Minor
    Found in lib/strategy.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            const provider = yield new Promise((res, rej) => {
              options.createProvider(req, function (err, provider) {
                if (err) {
                  throw err;
                }
      Severity: Major
      Found in lib/strategy.js and 1 other location - About 1 hr to fix
      lib/strategy.js on lines 67..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            const isValid = yield new Promise((res, rej) => {
              provider.valid_request(req, function (err, valid) {
                if (err) {
                  throw err;
                }
      Severity: Major
      Found in lib/strategy.js and 1 other location - About 1 hr to fix
      lib/strategy.js on lines 58..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language