relaton/relaton-nist

View on GitHub

Showing 11 of 13 total issues

Class TechPubsParser has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

  class TechPubsParser
    RELATION_TYPES = {
      "replaces" => "obsoletes",
      "isVersionOf" => "editionOf",
      "hasTranslation" => "hasTranslation",
Severity: Minor
Found in lib/relaton_nist/tech_pubs_parser.rb - About 2 hrs to fix

    Method select_data has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def select_data # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength,Metrics/PerceivedComplexity
          return [] unless refparts[:code]
    
          ref = "#{refparts[:series]} #{refparts[:code]}"
          d = Date.strptime year, "%Y" if year
    Severity: Minor
    Found in lib/relaton_nist/hit_collection.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method nistbib_results_filter has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

          def nistbib_results_filter(result, year, opts) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
            missed_years = []
            iter = /\w+(?=PD)|(?<=PD-)\w+/.match(opts[:stage])&.to_s
            iteration = case iter
                        when "I" then "1"
    Severity: Minor
    Found in lib/relaton_nist/nist_bibliography.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

          def get(code, year = nil, opts = {}) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
            return fetch_ref_err(code, year, []) if code.match?(/\sEP$/)
    
            /^(?<code2>[^(]+)(?:\((?<date2>\w+\s(?:\d{2},\s)?\d{4})\))?\s?\(?(?:(?<=\()(?<stage>(?:I|F|\d)PD))?/ =~ code
            stage ||= /(?<=\.)PD-\w+(?=\.)/.match(code)&.to_s
    Severity: Minor
    Found in lib/relaton_nist/nist_bibliography.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method contributors_json has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def contributors_json(doc, role, lang = "en", script = "Latn") # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/MethodLength,Metrics/PerceivedComplexity
            doc.map do |contr|
              if contr["affiliation"]
                if contr["affiliation"]["acronym"]
                  abbrev = RelatonBib::LocalizedString.new(contr["affiliation"]["acronym"])
    Severity: Minor
    Found in lib/relaton_nist/scrapper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method forename_initial has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def forename_initial(person) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
          fnames = []
          fname = person.at("given_name")&.text
          if fname
            if /^(?:(?<name>\w+)\s)?(?<inits>(?:\w(?:\.|\b)\s?)+)/ =~ fname
    Severity: Minor
    Found in lib/relaton_nist/tech_pubs_parser.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method search_filter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def search_filter # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity,Metrics/MethodLength
          arr = @array.select do |item|
            parts = doi_parts(item.hit[:json]) || code_parts(item.hit[:code])
            iteration = item.hit.dig(:json, "iteration")
            draft = parts[:draft] || (!iteration.nil? && iteration.match?(/\wpd/i))
    Severity: Minor
    Found in lib/relaton_nist/hit_collection.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method docidentifier has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def docidentifier(json) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength
          parts = doi_parts(json) || code_parts(json["docidentifier"])
          # return json["docidentifier"] unless parts
    
          id = parts[:code]
    Severity: Minor
    Found in lib/relaton_nist/hit_collection.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_date has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse_date
          @doc.xpath("publication_date|approval_date").map do |dt|
            on = dt.at("year").text
            if (m = dt.at "month")
              on += "-#{m.text}"
    Severity: Minor
    Found in lib/relaton_nist/tech_pubs_parser.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method doc_relation has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def doc_relation(type, ref, uri, lang = "en", script = "Latn") # rubocop:disable Metrics/MethodLength
    Severity: Minor
    Found in lib/relaton_nist/scrapper.rb - About 35 mins to fix

      Method to_xml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def to_xml(**opts)
            super date_format: :short, **opts do |b|
              if opts[:bibdata]
                ext = b.ext do
                  doctype&.to_xml b
      Severity: Minor
      Found in lib/relaton_nist/nist_bibliographic_item.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language