renyard/validity

View on GitHub
src/background/controller.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function validity has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var validity = (function(validity) {
    "use strict";
    var controller = {},
        net = validity.net,
        ui = validity.ui,
Severity: Major
Found in src/background/controller.js - About 3 hrs to fix

    Function validity has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

    var validity = (function(validity) {
        "use strict";
        var controller = {},
            net = validity.net,
            ui = validity.ui,
    Severity: Minor
    Found in src/background/controller.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function has a complexity of 11.
    Open

        controller.dispatch = function(request, sender) {
    Severity: Minor
    Found in src/background/controller.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function dispatch has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        controller.dispatch = function(request, sender) {
            var tabHost,
                enabledForHost,
                autoValidateForHost,
                response = {},
    Severity: Minor
    Found in src/background/controller.js - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status