renyard/validity

View on GitHub
src/background/xml.js

Summary

Maintainability
D
3 days
Test Coverage

Function validity has 97 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var validity = (function(validity) {
    "use strict";
    var xml = {},
        suppressed = [
            // Deprecated in favour of nu validator.
Severity: Major
Found in src/background/xml.js - About 3 hrs to fix

    Function parseResponse has 78 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        xml.parseResponse = function(xmlDom) {
            var response = {
                    "url": undefined,
                    "doctype": undefined,
                    "errorCount": undefined,
    Severity: Major
    Found in src/background/xml.js - About 3 hrs to fix

      Function has too many statements (42). Maximum allowed is 30.
      Open

          xml.parseResponse = function(xmlDom) {
      Severity: Minor
      Found in src/background/xml.js by eslint

      enforce a maximum number of statements allowed in function blocks (max-statements)

      The max-statements rule allows you to specify the maximum number of statements allowed in a function.

      function foo() {
        var bar = 1; // one statement
        var baz = 2; // two statements
        var qux = 3; // three statements
      }

      Rule Details

      This rule enforces a maximum number of statements allowed in function blocks.

      Options

      This rule has a number or object option:

      • "max" (default 10) enforces a maximum number of statements allows in function blocks

      Deprecated: The object property maximum is deprecated; please use the object property max instead.

      This rule has an object option:

      • "ignoreTopLevelFunctions": true ignores top-level functions

      max

      Examples of incorrect code for this rule with the default { "max": 10 } option:

      /*eslint max-statements: ["error", 10]*/
      /*eslint-env es6*/
      
      function foo() {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
      
        var foo11 = 11; // Too many.
      }
      
      let foo = () => {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
      
        var foo11 = 11; // Too many.
      };

      Examples of correct code for this rule with the default { "max": 10 } option:

      /*eslint max-statements: ["error", 10]*/
      /*eslint-env es6*/
      
      function foo() {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
        return function () {
      
          // The number of statements in the inner function does not count toward the
          // statement maximum.
      
          return 42;
        };
      }
      
      let foo = () => {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
        return function () {
      
          // The number of statements in the inner function does not count toward the
          // statement maximum.
      
          return 42;
        };
      }

      ignoreTopLevelFunctions

      Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

      /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/
      
      function foo() {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
        var foo11 = 11;
      }

      Related Rules

      • [complexity](complexity.md)
      • [max-depth](max-depth.md)
      • [max-len](max-len.md)
      • [max-nested-callbacks](max-nested-callbacks.md)
      • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

      Function validity has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      var validity = (function(validity) {
          "use strict";
          var xml = {},
              suppressed = [
                  // Deprecated in favour of nu validator.
      Severity: Minor
      Found in src/background/xml.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                      return 0;
      Severity: Major
      Found in src/background/xml.js - About 30 mins to fix

        'infoNodes' is not defined.
        Open

                    infos[j].lastLine = parseInt(_getFirstTagName(infoNodes[j], 'line').textContent, 10);
        Severity: Minor
        Found in src/background/xml.js by eslint

        Disallow Undeclared Variables (no-undef)

        This rule can help you locate potential ReferenceErrors resulting from misspellings of variable and parameter names, or accidental implicit globals (for example, from forgetting the var keyword in a for loop initializer).

        Rule Details

        Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment.

        Examples of incorrect code for this rule:

        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        Examples of correct code for this rule with global declaration:

        /*global someFunction b:true*/
        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        The b:true syntax in /*global */ indicates that assignment to b is correct.

        Examples of incorrect code for this rule with global declaration:

        /*global b*/
        /*eslint no-undef: "error"*/
        
        b = 10;

        By default, variables declared in /*global */ are read-only, therefore assignment is incorrect.

        Options

        • typeof set to true will warn for variables used inside typeof check (Default false).

        typeof

        Examples of correct code for the default { "typeof": false } option:

        /*eslint no-undef: "error"*/
        
        if (typeof UndefinedIdentifier === "undefined") {
            // do something ...
        }

        You can use this option if you want to prevent typeof check on a variable which has not been declared.

        Examples of incorrect code for the { "typeof": true } option:

        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Examples of correct code for the { "typeof": true } option with global declaration:

        /*global a*/
        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Environments

        For convenience, ESLint provides shortcuts that pre-define global variables exposed by popular libraries and runtime environments. This rule supports these environments, as listed in Specifying Environments. A few examples are given below.

        browser

        Examples of correct code for this rule with browser environment:

        /*eslint no-undef: "error"*/
        /*eslint-env browser*/
        
        setTimeout(function() {
            alert("Hello");
        });

        node

        Examples of correct code for this rule with node environment:

        /*eslint no-undef: "error"*/
        /*eslint-env node*/
        
        var fs = require("fs");
        module.exports = function() {
            console.log(fs);
        };

        When Not To Use It

        If explicit declaration of global variables is not to your taste.

        Compatibility

        This rule provides compatibility with treatment of global variables in JSHint and JSLint. Source: http://eslint.org/docs/rules/

        'infoNodes' is not defined.
        Open

                infoNodes = _getFirstTagName(xmlDom, 'infolist').getElementsByTagName('info');
        Severity: Minor
        Found in src/background/xml.js by eslint

        Disallow Undeclared Variables (no-undef)

        This rule can help you locate potential ReferenceErrors resulting from misspellings of variable and parameter names, or accidental implicit globals (for example, from forgetting the var keyword in a for loop initializer).

        Rule Details

        Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment.

        Examples of incorrect code for this rule:

        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        Examples of correct code for this rule with global declaration:

        /*global someFunction b:true*/
        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        The b:true syntax in /*global */ indicates that assignment to b is correct.

        Examples of incorrect code for this rule with global declaration:

        /*global b*/
        /*eslint no-undef: "error"*/
        
        b = 10;

        By default, variables declared in /*global */ are read-only, therefore assignment is incorrect.

        Options

        • typeof set to true will warn for variables used inside typeof check (Default false).

        typeof

        Examples of correct code for the default { "typeof": false } option:

        /*eslint no-undef: "error"*/
        
        if (typeof UndefinedIdentifier === "undefined") {
            // do something ...
        }

        You can use this option if you want to prevent typeof check on a variable which has not been declared.

        Examples of incorrect code for the { "typeof": true } option:

        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Examples of correct code for the { "typeof": true } option with global declaration:

        /*global a*/
        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Environments

        For convenience, ESLint provides shortcuts that pre-define global variables exposed by popular libraries and runtime environments. This rule supports these environments, as listed in Specifying Environments. A few examples are given below.

        browser

        Examples of correct code for this rule with browser environment:

        /*eslint no-undef: "error"*/
        /*eslint-env browser*/
        
        setTimeout(function() {
            alert("Hello");
        });

        node

        Examples of correct code for this rule with node environment:

        /*eslint no-undef: "error"*/
        /*eslint-env node*/
        
        var fs = require("fs");
        module.exports = function() {
            console.log(fs);
        };

        When Not To Use It

        If explicit declaration of global variables is not to your taste.

        Compatibility

        This rule provides compatibility with treatment of global variables in JSHint and JSLint. Source: http://eslint.org/docs/rules/

        'infoNodes' is not defined.
        Open

                    infos[j].message = _getFirstTagName(infoNodes[j], 'message').textContent;
        Severity: Minor
        Found in src/background/xml.js by eslint

        Disallow Undeclared Variables (no-undef)

        This rule can help you locate potential ReferenceErrors resulting from misspellings of variable and parameter names, or accidental implicit globals (for example, from forgetting the var keyword in a for loop initializer).

        Rule Details

        Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment.

        Examples of incorrect code for this rule:

        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        Examples of correct code for this rule with global declaration:

        /*global someFunction b:true*/
        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        The b:true syntax in /*global */ indicates that assignment to b is correct.

        Examples of incorrect code for this rule with global declaration:

        /*global b*/
        /*eslint no-undef: "error"*/
        
        b = 10;

        By default, variables declared in /*global */ are read-only, therefore assignment is incorrect.

        Options

        • typeof set to true will warn for variables used inside typeof check (Default false).

        typeof

        Examples of correct code for the default { "typeof": false } option:

        /*eslint no-undef: "error"*/
        
        if (typeof UndefinedIdentifier === "undefined") {
            // do something ...
        }

        You can use this option if you want to prevent typeof check on a variable which has not been declared.

        Examples of incorrect code for the { "typeof": true } option:

        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Examples of correct code for the { "typeof": true } option with global declaration:

        /*global a*/
        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Environments

        For convenience, ESLint provides shortcuts that pre-define global variables exposed by popular libraries and runtime environments. This rule supports these environments, as listed in Specifying Environments. A few examples are given below.

        browser

        Examples of correct code for this rule with browser environment:

        /*eslint no-undef: "error"*/
        /*eslint-env browser*/
        
        setTimeout(function() {
            alert("Hello");
        });

        node

        Examples of correct code for this rule with node environment:

        /*eslint no-undef: "error"*/
        /*eslint-env node*/
        
        var fs = require("fs");
        module.exports = function() {
            console.log(fs);
        };

        When Not To Use It

        If explicit declaration of global variables is not to your taste.

        Compatibility

        This rule provides compatibility with treatment of global variables in JSHint and JSLint. Source: http://eslint.org/docs/rules/

        'infoNodes' is not defined.
        Open

                    infos[j].lastColumn = parseInt(_getFirstTagName(infoNodes[j], 'col').textContent, 10);
        Severity: Minor
        Found in src/background/xml.js by eslint

        Disallow Undeclared Variables (no-undef)

        This rule can help you locate potential ReferenceErrors resulting from misspellings of variable and parameter names, or accidental implicit globals (for example, from forgetting the var keyword in a for loop initializer).

        Rule Details

        Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment.

        Examples of incorrect code for this rule:

        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        Examples of correct code for this rule with global declaration:

        /*global someFunction b:true*/
        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        The b:true syntax in /*global */ indicates that assignment to b is correct.

        Examples of incorrect code for this rule with global declaration:

        /*global b*/
        /*eslint no-undef: "error"*/
        
        b = 10;

        By default, variables declared in /*global */ are read-only, therefore assignment is incorrect.

        Options

        • typeof set to true will warn for variables used inside typeof check (Default false).

        typeof

        Examples of correct code for the default { "typeof": false } option:

        /*eslint no-undef: "error"*/
        
        if (typeof UndefinedIdentifier === "undefined") {
            // do something ...
        }

        You can use this option if you want to prevent typeof check on a variable which has not been declared.

        Examples of incorrect code for the { "typeof": true } option:

        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Examples of correct code for the { "typeof": true } option with global declaration:

        /*global a*/
        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Environments

        For convenience, ESLint provides shortcuts that pre-define global variables exposed by popular libraries and runtime environments. This rule supports these environments, as listed in Specifying Environments. A few examples are given below.

        browser

        Examples of correct code for this rule with browser environment:

        /*eslint no-undef: "error"*/
        /*eslint-env browser*/
        
        setTimeout(function() {
            alert("Hello");
        });

        node

        Examples of correct code for this rule with node environment:

        /*eslint no-undef: "error"*/
        /*eslint-env node*/
        
        var fs = require("fs");
        module.exports = function() {
            console.log(fs);
        };

        When Not To Use It

        If explicit declaration of global variables is not to your taste.

        Compatibility

        This rule provides compatibility with treatment of global variables in JSHint and JSLint. Source: http://eslint.org/docs/rules/

        'infoNodes' is not defined.
        Open

                    infoNodes;
        Severity: Minor
        Found in src/background/xml.js by eslint

        Disallow Undeclared Variables (no-undef)

        This rule can help you locate potential ReferenceErrors resulting from misspellings of variable and parameter names, or accidental implicit globals (for example, from forgetting the var keyword in a for loop initializer).

        Rule Details

        Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment.

        Examples of incorrect code for this rule:

        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        Examples of correct code for this rule with global declaration:

        /*global someFunction b:true*/
        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        The b:true syntax in /*global */ indicates that assignment to b is correct.

        Examples of incorrect code for this rule with global declaration:

        /*global b*/
        /*eslint no-undef: "error"*/
        
        b = 10;

        By default, variables declared in /*global */ are read-only, therefore assignment is incorrect.

        Options

        • typeof set to true will warn for variables used inside typeof check (Default false).

        typeof

        Examples of correct code for the default { "typeof": false } option:

        /*eslint no-undef: "error"*/
        
        if (typeof UndefinedIdentifier === "undefined") {
            // do something ...
        }

        You can use this option if you want to prevent typeof check on a variable which has not been declared.

        Examples of incorrect code for the { "typeof": true } option:

        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Examples of correct code for the { "typeof": true } option with global declaration:

        /*global a*/
        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Environments

        For convenience, ESLint provides shortcuts that pre-define global variables exposed by popular libraries and runtime environments. This rule supports these environments, as listed in Specifying Environments. A few examples are given below.

        browser

        Examples of correct code for this rule with browser environment:

        /*eslint no-undef: "error"*/
        /*eslint-env browser*/
        
        setTimeout(function() {
            alert("Hello");
        });

        node

        Examples of correct code for this rule with node environment:

        /*eslint no-undef: "error"*/
        /*eslint-env node*/
        
        var fs = require("fs");
        module.exports = function() {
            console.log(fs);
        };

        When Not To Use It

        If explicit declaration of global variables is not to your taste.

        Compatibility

        This rule provides compatibility with treatment of global variables in JSHint and JSLint. Source: http://eslint.org/docs/rules/

        'infoNodes' is not defined.
        Open

                    infos[j].messageid = _getFirstTagName(infoNodes[j], 'messageid').textContent;
        Severity: Minor
        Found in src/background/xml.js by eslint

        Disallow Undeclared Variables (no-undef)

        This rule can help you locate potential ReferenceErrors resulting from misspellings of variable and parameter names, or accidental implicit globals (for example, from forgetting the var keyword in a for loop initializer).

        Rule Details

        Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment.

        Examples of incorrect code for this rule:

        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        Examples of correct code for this rule with global declaration:

        /*global someFunction b:true*/
        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        The b:true syntax in /*global */ indicates that assignment to b is correct.

        Examples of incorrect code for this rule with global declaration:

        /*global b*/
        /*eslint no-undef: "error"*/
        
        b = 10;

        By default, variables declared in /*global */ are read-only, therefore assignment is incorrect.

        Options

        • typeof set to true will warn for variables used inside typeof check (Default false).

        typeof

        Examples of correct code for the default { "typeof": false } option:

        /*eslint no-undef: "error"*/
        
        if (typeof UndefinedIdentifier === "undefined") {
            // do something ...
        }

        You can use this option if you want to prevent typeof check on a variable which has not been declared.

        Examples of incorrect code for the { "typeof": true } option:

        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Examples of correct code for the { "typeof": true } option with global declaration:

        /*global a*/
        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Environments

        For convenience, ESLint provides shortcuts that pre-define global variables exposed by popular libraries and runtime environments. This rule supports these environments, as listed in Specifying Environments. A few examples are given below.

        browser

        Examples of correct code for this rule with browser environment:

        /*eslint no-undef: "error"*/
        /*eslint-env browser*/
        
        setTimeout(function() {
            alert("Hello");
        });

        node

        Examples of correct code for this rule with node environment:

        /*eslint no-undef: "error"*/
        /*eslint-env node*/
        
        var fs = require("fs");
        module.exports = function() {
            console.log(fs);
        };

        When Not To Use It

        If explicit declaration of global variables is not to your taste.

        Compatibility

        This rule provides compatibility with treatment of global variables in JSHint and JSLint. Source: http://eslint.org/docs/rules/

        'infoNodes' is not defined.
        Open

                for (var j = 0; j < infoNodes.length; j++) {
        Severity: Minor
        Found in src/background/xml.js by eslint

        Disallow Undeclared Variables (no-undef)

        This rule can help you locate potential ReferenceErrors resulting from misspellings of variable and parameter names, or accidental implicit globals (for example, from forgetting the var keyword in a for loop initializer).

        Rule Details

        Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment.

        Examples of incorrect code for this rule:

        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        Examples of correct code for this rule with global declaration:

        /*global someFunction b:true*/
        /*eslint no-undef: "error"*/
        
        var a = someFunction();
        b = 10;

        The b:true syntax in /*global */ indicates that assignment to b is correct.

        Examples of incorrect code for this rule with global declaration:

        /*global b*/
        /*eslint no-undef: "error"*/
        
        b = 10;

        By default, variables declared in /*global */ are read-only, therefore assignment is incorrect.

        Options

        • typeof set to true will warn for variables used inside typeof check (Default false).

        typeof

        Examples of correct code for the default { "typeof": false } option:

        /*eslint no-undef: "error"*/
        
        if (typeof UndefinedIdentifier === "undefined") {
            // do something ...
        }

        You can use this option if you want to prevent typeof check on a variable which has not been declared.

        Examples of incorrect code for the { "typeof": true } option:

        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Examples of correct code for the { "typeof": true } option with global declaration:

        /*global a*/
        /*eslint no-undef: ["error", { "typeof": true }] */
        
        if(typeof a === "string"){}

        Environments

        For convenience, ESLint provides shortcuts that pre-define global variables exposed by popular libraries and runtime environments. This rule supports these environments, as listed in Specifying Environments. A few examples are given below.

        browser

        Examples of correct code for this rule with browser environment:

        /*eslint no-undef: "error"*/
        /*eslint-env browser*/
        
        setTimeout(function() {
            alert("Hello");
        });

        node

        Examples of correct code for this rule with node environment:

        /*eslint no-undef: "error"*/
        /*eslint-env node*/
        
        var fs = require("fs");
        module.exports = function() {
            console.log(fs);
        };

        When Not To Use It

        If explicit declaration of global variables is not to your taste.

        Compatibility

        This rule provides compatibility with treatment of global variables in JSHint and JSLint. Source: http://eslint.org/docs/rules/

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for (var j = 0; j < infoNodes.length; j++) {
                    //    Create object for info messages
                    infos[j] = {};
        
                    infos[j].lastLine = parseInt(_getFirstTagName(infoNodes[j], 'line').textContent, 10);
        Severity: Major
        Found in src/background/xml.js and 1 other location - About 1 day to fix
        src/background/xml.js on lines 65..75

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 197.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                for (var j = 0; j < warningNodes.length; j++) {
                    //    Create object for warning
                    warnings[j] = {};
        
                    warnings[j].lastLine = parseInt(_getFirstTagName(warningNodes[j], 'line').textContent, 10);
        Severity: Major
        Found in src/background/xml.js and 1 other location - About 1 day to fix
        src/background/xml.js on lines 78..88

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 197.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status