Sign upLogin

rescribet/link-lib

View on GitHub
Star

Showing 153 of 153 total issues

Avoid too many return statements within this function.
Open

        return this.currentBroadcast = new ProcessBroadcast({
            bulkSubscriptions: this.bulkSubscriptions.slice(),
            changedSubjects: subjects,
            subjectSubscriptions: Array.from(subjectRegs),
            timeout: maxTimeout,
Severity: Major
Found in src/LinkedRenderStore.ts - About 30 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    export const invalidateAllWithProperty = (field: string, value: SomeTerm): InvalidateAllWithPropertyMessage => ({
  type: "InvalidateAllWithProperty",
  field,
  value,
});
    Severity: Minor
    Found in src/messages/message.ts and 2 other locations - About 30 mins to fix
    src/messages/message.ts on lines 85..89
    src/messages/message.ts on lines 105..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

            return rdfFactory.namedNode(prop);
    Severity: Major
    Found in src/utilities/memoizedNamespace.ts - About 30 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      export const deleteAllFieldsMatching = (field: string, value: SomeTerm): DeleteAllFieldsMatchingMessage => ({
  type: "DeleteAllFieldsMatching",
  field,
  value,
});
      Severity: Minor
      Found in src/messages/message.ts and 2 other locations - About 30 mins to fix
      src/messages/message.ts on lines 85..89
      src/messages/message.ts on lines 129..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

          return undefined;
      Severity: Major
      Found in src/utilities/responses.ts - About 30 mins to fix

        Function getResourceProperties has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public getResourceProperties<TT extends Term = Term>(subject: SomeNode, property: SomeNode | SomeNode[]): TT[] {
        if (property === rdf.type) {
            const value = this.store.store.getField(subject.value, rdf.type.value);

            if (!value) {
        Severity: Minor
        Found in src/RDFStore.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function process has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private process(record: DataRecord): void {
        for (const vocab of Schema.vocabularies) {
            for (const [field, values] of Object.entries(record)) {
                for (const value of normalizeType(values)) {
                    vocab.processStatement(
        Severity: Minor
        Found in src/Schema.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addField has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          public addField(recordId: Id, field: FieldId, value: SomeTerm): boolean {
    if (field === idField) {
      throw new Error("Can't set system fields");
    }
    this.initializeRecord(recordId);
        Severity: Minor
        Found in src/store/StructuredStore.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function exactMatch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private exactMatch(types: Id[], fields: Id[], topology: Id): T | undefined {
        for (const field of fields) {
            for (const type of types) {
                const exact = this.lookup(field, type, topology);
                if (exact !== undefined) {
        Severity: Minor
        Found in src/ComponentStore/ComponentStore.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function subscribe has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public subscribe(registration: SubscriptionRegistrationBase<unknown>): () => void {
        registration.subscribedAt = Date.now();
        const subjectFilter = registration.subjectFilter
          ?.flatMap((s) => [s, this.store.getInternalStore().store.primary(s)]);
        Severity: Minor
        Found in src/LinkedRenderStore.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getTermBestLang has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export function getTermBestLang(rawTerm: Term | Term[], langPrefs: string[]): Term {
    if (!Array.isArray(rawTerm)) {
        return rawTerm;
    }
    if (rawTerm.length === 1) {
        Severity: Minor
        Found in src/utilities.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function hasReferenceTo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export const hasReferenceTo = (record: DataRecord, referenced: Id): boolean => {
  for (const field in record) {
    if (!record.hasOwnProperty(field) || field === idField) {
      continue;
    }
        Severity: Minor
        Found in src/store/StructuredStore/references.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getHeader has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export function getHeader(res: ResponseAndFallbacks, header: string): string | null {
    if (res instanceof Response) {
        return res.headers.get(header);
    } else if (typeof XMLHttpRequest !== "undefined" && res instanceof XMLHttpRequest) {
        return (res as XMLHttpRequest).getResponseHeader(header) || null;
        Severity: Minor
        Found in src/utilities/responses.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language