resource-watch/adapter-earth-engine

View on GitHub

Showing 5 of 13 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

@app.errorhandler(404)
def page_not_found(e):
    logging.error("Not Found")
    return error(status=404, detail="Not Found")
Severity: Major
Found in adapterearthengine/__init__.py and 4 other locations - About 45 mins to fix
adapterearthengine/__init__.py on lines 51..54
adapterearthengine/__init__.py on lines 63..66
adapterearthengine/__init__.py on lines 69..72
adapterearthengine/__init__.py on lines 75..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

@app.errorhandler(403)
def forbidden(e):
    logging.error("Forbidden")
    return error(status=403, detail="Forbidden")
Severity: Major
Found in adapterearthengine/__init__.py and 4 other locations - About 45 mins to fix
adapterearthengine/__init__.py on lines 57..60
adapterearthengine/__init__.py on lines 63..66
adapterearthengine/__init__.py on lines 69..72
adapterearthengine/__init__.py on lines 75..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

@app.errorhandler(405)
def method_not_allowed(e):
    logging.error("Method Not Allowed")
    return error(status=405, detail="Method Not Allowed")
Severity: Major
Found in adapterearthengine/__init__.py and 4 other locations - About 45 mins to fix
adapterearthengine/__init__.py on lines 51..54
adapterearthengine/__init__.py on lines 57..60
adapterearthengine/__init__.py on lines 69..72
adapterearthengine/__init__.py on lines 75..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

@app.errorhandler(410)
def gone(e):
    logging.error("Gone")
    return error(status=410, detail="Gone")
Severity: Major
Found in adapterearthengine/__init__.py and 4 other locations - About 45 mins to fix
adapterearthengine/__init__.py on lines 51..54
adapterearthengine/__init__.py on lines 57..60
adapterearthengine/__init__.py on lines 63..66
adapterearthengine/__init__.py on lines 75..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

@app.errorhandler(500)
def internal_server_error(e):
    logging.error("Internal Server Error")
    return error(status=500, detail="Internal Server Error")
Severity: Major
Found in adapterearthengine/__init__.py and 4 other locations - About 45 mins to fix
adapterearthengine/__init__.py on lines 51..54
adapterearthengine/__init__.py on lines 57..60
adapterearthengine/__init__.py on lines 63..66
adapterearthengine/__init__.py on lines 69..72

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language