resource-watch/converter

View on GitHub

Showing 41 of 41 total issues

Function obtainFSFromAST has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

    static obtainFSFromAST(parsed) {
        logger.info('Generating FeatureService object from ast object');
        let fs = {};

        if (parsed.select && parsed.select.length > 0) {
Severity: Minor
Found in app/src/services/converterService.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File converterService.js has 408 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const logger = require('logger');
const SQLService = require('services/sqlService');
const { geojsonToArcGIS } = require('arcgis-to-geojson-utils');
const { arcgisToGeoJSON } = require('arcgis-to-geojson-utils');
const Sql2json = require('sql2json').sql2json;
Severity: Minor
Found in app/src/services/converterService.js - About 5 hrs to fix

    Function sql2SQL has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static async sql2SQL(data, apiKey, isRaster = false, experimental = false) {
            logger.debug('Converting sql to sql', data);
            const parsed = new Sql2json(data.sql, experimental).toJSON();
            if (!parsed) {
                return SQLService.generateError('Malformed query');
    Severity: Major
    Found in app/src/services/sqlService.js - About 3 hrs to fix

      Function obtainFSFromAST has 85 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static obtainFSFromAST(parsed) {
              logger.info('Generating FeatureService object from ast object');
              let fs = {};
      
              if (parsed.select && parsed.select.length > 0) {
      Severity: Major
      Found in app/src/services/converterService.js - About 3 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            static checkGeojson(geojson) {
                if (geojson.type.toLowerCase() === 'polygon') {
                    return {
                        type: 'FeatureCollection',
                        features: [{
        Severity: Major
        Found in app/src/services/converterService.js and 1 other location - About 3 hrs to fix
        app/src/services/sqlService.js on lines 69..86

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            static checkGeojson(geojson) {
                if (geojson.type.toLowerCase() === 'polygon') {
                    return {
                        type: 'FeatureCollection',
                        features: [{
        Severity: Major
        Found in app/src/services/sqlService.js and 1 other location - About 3 hrs to fix
        app/src/services/converterService.js on lines 392..409

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function obtainSelect has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

            static obtainSelect(fs) {
                let result = '';
                if (!fs.outFields && !fs.outStatistics) {
                    return '*';
                }
        Severity: Minor
        Found in app/src/services/converterService.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function findIntersect has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            static findIntersect(node, found, result) {
                if (node && node.type === 'string' && node.value && found) {
                    try {
                        const geojson = JSON.parse(node.value);
                        if (!result) {
        Severity: Minor
        Found in app/src/services/converterService.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function exports has 70 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = (grunt) => {
        
            grunt.file.setBase('..');
            // eslint-disable-next-line import/no-extraneous-dependencies
            require('load-grunt-tasks')(grunt);
        Severity: Major
        Found in app/Gruntfile.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              arguments: [{
                                  type: 'function',
                                  value: 'ST_SetSRID',
                                  arguments: [{
                                      type: 'function',
          Severity: Major
          Found in app/src/services/sqlService.js and 1 other location - About 2 hrs to fix
          app/src/services/sqlService.js on lines 140..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 89.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              arguments: [{
                                  type: 'function',
                                  value: 'ST_SetSRID',
                                  arguments: [{
                                      type: 'function',
          Severity: Major
          Found in app/src/services/sqlService.js and 1 other location - About 2 hrs to fix
          app/src/services/sqlService.js on lines 110..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 89.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function obtainWhere has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

              static async obtainWhere(params, apiKey) {
                  const fs = params;
                  let where = '';
                  if (fs.where) {
                      if (!where) {
          Severity: Minor
          Found in app/src/services/converterService.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function sql2SQL has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              static async sql2SQL(data, apiKey, isRaster = false, experimental = false) {
                  logger.debug('Converting sql to sql', data);
                  const parsed = new Sql2json(data.sql, experimental).toJSON();
                  if (!parsed) {
                      return SQLService.generateError('Malformed query');
          Severity: Minor
          Found in app/src/services/sqlService.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function init has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          async function init() {
              return new Promise((resolve) => {
          
                  const app = new Koa();
          
          
          Severity: Minor
          Found in app/src/app.js - About 1 hr to fix

            Function exports has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = (() => {
            
                const loadAPI = (app, path, pathApi) => {
                    const routesFiles = fs.readdirSync(path);
                    let existIndexRouter = false;
            Severity: Minor
            Found in app/src/loader.js - About 1 hr to fix

              Function obtainWhere has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  static async obtainWhere(params, apiKey) {
                      const fs = params;
                      let where = '';
                      if (fs.where) {
                          if (!where) {
              Severity: Minor
              Found in app/src/services/converterService.js - About 1 hr to fix

                Function findIntersect has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    static findIntersect(node, found, result) {
                        if (node && node.type === 'string' && node.value && found) {
                            try {
                                const geojson = JSON.parse(node.value);
                                if (!result) {
                Severity: Minor
                Found in app/src/services/converterService.js - About 1 hr to fix

                  Function loadAPI has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      const loadAPI = (app, path, pathApi) => {
                          const routesFiles = fs.readdirSync(path);
                          let existIndexRouter = false;
                          routesFiles.forEach((file) => {
                              const newPath = path ? (`${path}/${file}`) : file;
                  Severity: Minor
                  Found in app/src/loader.js - About 1 hr to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                            if (pathApi) {
                                                app.use(mount(pathApi, require(newPath).middleware()));
                                            } else {
                                                app.use(require(newPath).middleware());
                                            }
                    Severity: Major
                    Found in app/src/loader.js and 1 other location - About 1 hr to fix
                    app/src/loader.js on lines 42..46

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 60.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (pathApi) {
                                    app.use(mount(pathApi, require(newPath).middleware()));
                                } else {
                                    app.use(require(newPath).middleware());
                                }
                    Severity: Major
                    Found in app/src/loader.js and 1 other location - About 1 hr to fix
                    app/src/loader.js on lines 25..29

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 60.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language