resource-watch/dataset

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        koaObj.checkBody('data').optional().check((data) => {
            if (DatasetValidator.isArray(data) || DatasetValidator.isObject(data)) {
                return true;
            }
            return false;

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    static async deleteWidgets(datasetId, apiKey) {
        logger.info('Deleting widgets of dataset', datasetId);
        await RWAPIMicroservice.requestToMicroservice({
            uri: `/v1/dataset/${datasetId}/widget`,
            method: 'DELETE',

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    static async deleteMetadata(datasetId, apiKey) {
        logger.info('Deleting metadata of dataset', datasetId);
        await RWAPIMicroservice.requestToMicroservice({
            uri: `/v1/dataset/${datasetId}/metadata`,
            method: 'DELETE',

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        koaObj.checkBody('data').optional().check((data) => {
            if (DatasetValidator.isArray(data) || DatasetValidator.isObject(data)) {
                return true;
            }
            return false;

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    static async deleteVocabularies(datasetId, apiKey) {
        logger.info('Deleting vocabularies of dataset', datasetId);
        await RWAPIMicroservice.requestToMicroservice({
            uri: `/v1/dataset/${datasetId}/vocabulary`,
            method: 'DELETE',

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    static async deleteLayers(datasetId, apiKey) {
        logger.info('Deleting layers of dataset', datasetId);
        await RWAPIMicroservice.requestToMicroservice({
            uri: `/v1/dataset/${datasetId}/layer`,
            method: 'DELETE',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            const result = await RWAPIMicroservice.requestToMicroservice({
                uri: `/v1/favourite/find-by-user`,
                method: 'POST',
                json: true,
                body: {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            const result = await RWAPIMicroservice.requestToMicroservice({
                uri: `/v1/collection/find-by-ids`,
                method: 'POST',
                json: true,
                body: {

• Read up
  Read up

Function clone has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    static async clone(id, dataset, user, apiKey, fullCloning = false) {
        logger.debug(`[DatasetService]: Getting dataset with id:  ${id}`);
        logger.info(`[DBACCESS-FIND]: dataset.id: ${id}`);
        const currentDataset = await Dataset.findById(id).exec() || await Dataset.findOne({
            slug: id

Function authorizationMiddleware has 36 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const authorizationMiddleware = async (ctx, next) => {
    logger.info(`[DatasetRouter] Checking authorization`);
    // Get user from query (delete) or body (post-patch)
    const newDatasetCreation = ctx.request.path === '/dataset' && ctx.request.method === 'POST';
    const uploadDataset = ctx.request.path.indexOf('upload') >= 0 && ctx.request.method === 'POST';

Function checkSecureDeleteResources has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    static async checkSecureDeleteResources(id, apiKey) {
        logger.info('Checking if it is safe to delete the associated resources (layer, widget) of the dataset');
        try {
            const layers = await RWAPIMicroservice.requestToMicroservice({
                uri: `/v1/dataset/${id}/layer?protected=true`,

Function serialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    static serialize(data, link = null) {
        const result = {};
        if (data && Array.isArray(data) && data.length === 0) {
            result.data = [];
            return result;

Function update has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    static async update(ctx) {
        const id = ctx.params.dataset;
        logger.info(`[DatasetRouter] Updating dataset with id: ${id}`);
        try {
            const user = DatasetRouter.getUser(ctx);

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                try {
                    logger.debug('[DatasetService]: Creating relations in graph');
                    await GraphService.associateTags(newDataset._id, dataset.vocabularies, apiKey);
                } catch (err) {
                    newDataset.errorMessage = err.message;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if (
            sort.indexOf('most-favorited') >= 0
            || sort.indexOf('most-viewed') >= 0
            || sort.indexOf('relevance') >= 0
            || sort.indexOf('metadata') >= 0

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            try {
                await RelationshipsService.createVocabularies(newDataset._id, dataset.vocabularies, apiKey);
            } catch (err) {
                newDataset.errorMessage = err.message;
                const result = await DatasetService.update(newDataset._id, newDataset, {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if (
            sort.indexOf('most-favorited') >= 0
            || sort.indexOf('most-viewed') >= 0
            || sort.indexOf('relevance') >= 0
            || sort.indexOf('metadata') >= 0

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

            if (
                search
                || serializeObjToQuery(query).indexOf('concepts[0][0]') >= 0
                || sort.indexOf('most-favorited') >= 0
                || sort.indexOf('most-viewed') >= 0

Function getRelationships has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    static async getRelationships(datasets, includes, apiKey, query = '', isAdmin = false) {
        logger.info(`Getting relationships of datasets`, isAdmin);
        datasets.unshift({});
        const map = datasets.reduce((acc, val) => {
            acc[val._id] = val;

Function notifyAdapterCreate has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    static async notifyAdapterCreate(ctx, dataset) {
        const { connectorType, provider } = dataset;
        const clonedDataset = { ...dataset.toObject() };

        clonedDataset.id = dataset._id;