resource-watch/rw_metadata

View on GitHub

Showing 32 of 32 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class CloneNotValid extends Error {

    constructor(messages) {
        super(messages);
        this.name = 'CloneNotValid';
Severity: Major
Found in app/src/errors/cloneNotValid.error.js and 1 other location - About 4 hrs to fix
app/src/errors/metadataNotValid.error.js on lines 2..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class MetadataNotValid extends Error {

    constructor(messages) {
        super(messages);
        this.name = 'MetadataNotValid';
Severity: Major
Found in app/src/errors/metadataNotValid.error.js and 1 other location - About 4 hrs to fix
app/src/errors/cloneNotValid.error.js on lines 2..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (grunt) => {

    grunt.file.setBase('..');
    // eslint-disable-next-line import/no-extraneous-dependencies
    require('load-grunt-tasks')(grunt);
Severity: Major
Found in app/Gruntfile.js - About 3 hrs to fix

    Function authorizationMiddleware has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    const authorizationMiddleware = async (ctx, next) => {
        // Get user from query (delete) or body (post-patch)
        const user = { ...(ctx.request.query.loggedUser ? JSON.parse(ctx.request.query.loggedUser) : {}), ...ctx.request.body.loggedUser };
        if (user.id === 'microservice') {
            await next();
    Severity: Minor
    Found in app/src/routes/api/v1/metadata.router.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const cloneValidationMiddleware = async (ctx, next) => {
        try {
            MetadataValidator.validateClone(ctx);
        } catch (err) {
            if (err instanceof CloneNotValid) {
    Severity: Major
    Found in app/src/routes/api/v1/metadata.router.js and 1 other location - About 2 hrs to fix
    app/src/routes/api/v1/metadata.router.js on lines 212..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const validationMiddleware = async (ctx, next) => {
        try {
            MetadataValidator.validate(ctx);
        } catch (err) {
            if (err instanceof MetadataNotValid) {
    Severity: Major
    Found in app/src/routes/api/v1/metadata.router.js and 1 other location - About 2 hrs to fix
    app/src/routes/api/v1/metadata.router.js on lines 226..237

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function exports has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = (() => {
    
        const loadAPI = (app, path, pathApi) => {
            const routesFiles = fs.readdirSync(path);
            let existIndexRouter = false;
    Severity: Minor
    Found in app/src/loader.js - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              const currentMetadata = await Metadata.findOne({
                  dataset,
                  'resource.id': resource.id,
                  'resource.type': resource.type,
                  application: body.application,
      Severity: Major
      Found in app/src/services/metadata.service.js and 2 other locations - About 1 hr to fix
      app/src/services/metadata.service.js on lines 94..100
      app/src/services/metadata.service.js on lines 202..208

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              const metadata = await Metadata.findOne({
                  dataset,
                  'resource.id': resource.id,
                  'resource.type': resource.type,
                  application: body.application,
      Severity: Major
      Found in app/src/services/metadata.service.js and 2 other locations - About 1 hr to fix
      app/src/services/metadata.service.js on lines 52..58
      app/src/services/metadata.service.js on lines 94..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              const metadata = await Metadata.findOne({
                  dataset,
                  'resource.id': resource.id,
                  'resource.type': resource.type,
                  application: body.application,
      Severity: Major
      Found in app/src/services/metadata.service.js and 2 other locations - About 1 hr to fix
      app/src/services/metadata.service.js on lines 52..58
      app/src/services/metadata.service.js on lines 202..208

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function validate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static validate(koaObj) {
              logger.info('Validating Metadata Creation');
              koaObj.checkBody('language').notEmpty().check((lang) => MetadataValidator.isString(lang)).toLow();
              koaObj.checkBody('application').notEmpty().check((application) => MetadataValidator.notEmptyString(application));
              koaObj.checkBody('name').optional().check((name) => MetadataValidator.isString(name), 'should be a valid string');
      Severity: Minor
      Found in app/src/validators/metadata.validator.js - About 1 hr to fix

        Function serialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static serialize(data) {
        
                const result = {
                    data: []
                };
        Severity: Minor
        Found in app/src/serializers/metadata.serializer.js - About 1 hr to fix

          Function authorizationMiddleware has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const authorizationMiddleware = async (ctx, next) => {
              // Get user from query (delete) or body (post-patch)
              const user = { ...(ctx.request.query.loggedUser ? JSON.parse(ctx.request.query.loggedUser) : {}), ...ctx.request.body.loggedUser };
              if (user.id === 'microservice') {
                  await next();
          Severity: Minor
          Found in app/src/routes/api/v1/metadata.router.js - About 1 hr to fix

            Function loadAPI has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                const loadAPI = (app, path, pathApi) => {
                    const routesFiles = fs.readdirSync(path);
                    let existIndexRouter = false;
                    routesFiles.forEach((file) => {
                        const newPath = path ? (`${path}/${file}`) : file;
            Severity: Minor
            Found in app/src/loader.js - About 1 hr to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (pathApi) {
                              app.use(mount(pathApi, require(newPath).middleware()));
                          } else {
                              app.use(require(newPath).middleware());
                          }
              Severity: Major
              Found in app/src/loader.js and 1 other location - About 1 hr to fix
              app/src/loader.js on lines 24..28

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                      if (pathApi) {
                                          app.use(mount(pathApi, require(newPath).middleware()));
                                      } else {
                                          app.use(require(newPath).middleware());
                                      }
              Severity: Major
              Found in app/src/loader.js and 1 other location - About 1 hr to fix
              app/src/loader.js on lines 41..45

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function getAll has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  static async getAll(filter, extendedFilter) {
                      const finalFilter = MetadataService.getFilter(filter);
                      let projection = null;
                      const options = {};
                      if (filter.sort) {
              Severity: Minor
              Found in app/src/services/metadata.service.js - About 1 hr to fix

                Function create has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    static async create(user, dataset, resource, body) {
                        logger.debug('Checking if metadata exists');
                        const currentMetadata = await Metadata.findOne({
                            dataset,
                            'resource.id': resource.id,
                Severity: Minor
                Found in app/src/services/metadata.service.js - About 1 hr to fix

                  Function update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      static async update(dataset, resource, body) {
                          const metadata = await Metadata.findOne({
                              dataset,
                              'resource.id': resource.id,
                              'resource.type': resource.type,
                  Severity: Minor
                  Found in app/src/services/metadata.service.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          koaObj.checkBody('columns').optional().check((columns) => {
                              if (MetadataValidator.isObject(columns)) {
                                  return true;
                              }
                              return false;
                  Severity: Major
                  Found in app/src/validators/metadata.validator.js and 2 other locations - About 55 mins to fix
                  app/src/validators/metadata.validator.js on lines 81..86
                  app/src/validators/metadata.validator.js on lines 87..92

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language