rest-client/rest-client

View on GitHub

Showing 8 of 8 total issues

File request.rb has 481 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'tempfile'
require 'cgi'
require 'netrc'
require 'set'

Severity: Minor
Found in lib/restclient/request.rb - About 7 hrs to fix

    Class Request has 33 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Request
    
        attr_reader :method, :uri, :url, :headers, :payload, :proxy,
                    :user, :password, :read_timeout, :max_redirects,
                    :open_timeout, :raw_response, :processed_headers, :args,
    Severity: Minor
    Found in lib/restclient/request.rb - About 4 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def post(payload, additional_headers={}, &block)
            headers = (options[:headers] || {}).merge(additional_headers)
            Request.execute(options.merge(
                    :method => :post,
                    :url => url,
      Severity: Minor
      Found in lib/restclient/resource.rb and 2 other locations - About 25 mins to fix
      lib/restclient/resource.rb on lines 77..84
      lib/restclient/resource.rb on lines 87..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def patch(payload, additional_headers={}, &block)
            headers = (options[:headers] || {}).merge(additional_headers)
            Request.execute(options.merge(
                    :method => :patch,
                    :url => url,
      Severity: Minor
      Found in lib/restclient/resource.rb and 2 other locations - About 25 mins to fix
      lib/restclient/resource.rb on lines 67..74
      lib/restclient/resource.rb on lines 77..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def put(payload, additional_headers={}, &block)
            headers = (options[:headers] || {}).merge(additional_headers)
            Request.execute(options.merge(
                    :method => :put,
                    :url => url,
      Severity: Minor
      Found in lib/restclient/resource.rb and 2 other locations - About 25 mins to fix
      lib/restclient/resource.rb on lines 67..74
      lib/restclient/resource.rb on lines 87..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def head(additional_headers={}, &block)
            headers = (options[:headers] || {}).merge(additional_headers)
            Request.execute(options.merge(
                    :method => :head,
                    :url => url,
      Severity: Minor
      Found in lib/restclient/resource.rb and 2 other locations - About 25 mins to fix
      lib/restclient/resource.rb on lines 49..55
      lib/restclient/resource.rb on lines 97..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def delete(additional_headers={}, &block)
            headers = (options[:headers] || {}).merge(additional_headers)
            Request.execute(options.merge(
                    :method => :delete,
                    :url => url,
      Severity: Minor
      Found in lib/restclient/resource.rb and 2 other locations - About 25 mins to fix
      lib/restclient/resource.rb on lines 49..55
      lib/restclient/resource.rb on lines 58..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def get(additional_headers={}, &block)
            headers = (options[:headers] || {}).merge(additional_headers)
            Request.execute(options.merge(
                    :method => :get,
                    :url => url,
      Severity: Minor
      Found in lib/restclient/resource.rb and 2 other locations - About 25 mins to fix
      lib/restclient/resource.rb on lines 58..64
      lib/restclient/resource.rb on lines 97..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language