rhenium/plum

View on GitHub
lib/plum/client.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method _request_helper has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _request_helper(method, path, body, options, &block)
Severity: Minor
Found in lib/plum/client.rb - About 35 mins to fix

    Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(host, port = nil, config = {})
          if host.is_a?(IO)
            @socket = host
          else
            @socket = nil
    Severity: Minor
    Found in lib/plum/client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _start has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def _start
          @started = true
          nego = @socket || _connect
    
          if @config[:https]
    Severity: Minor
    Found in lib/plum/client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status