riboseinc/metanorma-csd

View on GitHub

Showing 7 of 9 total issues

Method sections_sequence_validate has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def sections_sequence_validate(root)
        f = root.xpath(SECTIONS_XPATH)
        names = f.map { |s| { tag: s.name, title: s&.at("./title")&.text } }
        names = seqcheck(names, SEQ[0][:msg], SEQ[0][:val]) || return
        n = names[0]
Severity: Minor
Found in lib/asciidoctor/csd/validate_section.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sections_sequence_validate has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def sections_sequence_validate(root)
        f = root.xpath(SECTIONS_XPATH)
        names = f.map { |s| { tag: s.name, title: s&.at("./title")&.text } }
        names = seqcheck(names, SEQ[0][:msg], SEQ[0][:val]) || return
        n = names[0]
Severity: Minor
Found in lib/asciidoctor/csd/validate_section.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return
    Severity: Major
    Found in lib/asciidoctor/csd/validate_section.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return
      Severity: Major
      Found in lib/asciidoctor/csd/validate_section.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                  n = names.shift || return
        Severity: Major
        Found in lib/asciidoctor/csd/validate_section.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    n = names.shift || return
          Severity: Major
          Found in lib/asciidoctor/csd/validate_section.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    n = names.shift || return
            Severity: Major
            Found in lib/asciidoctor/csd/validate_section.rb - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language