Sign upLogin

rkday/ruby-diameter

View on GitHub
Star

Showing 16 of 16 total issues

File avp_names.rb has 996 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Diameter
  module Constants
    include AVPType
    include Vendors
Severity: Major
Found in lib/diameter/avp_names.rb - About 2 days to fix

    Class AVP has 30 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class AVP
    include Internals
    include Constants::AVPType
    attr_reader :code, :mandatory, :vendor_id
    Severity: Minor
    Found in lib/diameter/avp.rb - About 3 hrs to fix

      File stack.rb has 274 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'uri'
require 'socket'
require 'diameter/peer'
require 'diameter/message'
require 'diameter/stack_transport_helpers'
      Severity: Minor
      Found in lib/diameter/stack.rb - About 2 hrs to fix

        Class Stack has 22 methods (exceeds 20 allowed). Consider refactoring.
        Open

          class Stack
    include Internals

    # @!group Setup methods
        Severity: Minor
        Found in lib/diameter/stack.rb - About 2 hrs to fix

          Method send_request has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def send_request(req, options={})
      fail "Must pass a request" unless req.request
      req.add_origin_host_and_realm(@local_host, @local_realm)

      peer = options[:peer]
          Severity: Minor
          Found in lib/diameter/stack.rb - About 1 hr to fix

            Method handle_message has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                def handle_message(msg_bytes, cxn)
      # Common processing - ensure that this message has come in on this
      # peer's expected connection, and update the last time we saw
      # activity on this peer
      msg = Message.from_bytes(msg_bytes)
            Severity: Minor
            Found in lib/diameter/stack.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method send_request has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def send_request(req, options={})
      fail "Must pass a request" unless req.request
      req.add_origin_host_and_realm(@local_host, @local_realm)

      peer = options[:peer]
            Severity: Minor
            Found in lib/diameter/stack.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method to_s has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def to_s
      has_all_ascii_values =
        @content.bytes.reject { |c| (32 < c && c < 126) }.empty?

      could_be_32bit_num = (@content.length == 4)
            Severity: Minor
            Found in lib/diameter/avp.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                avps = [AVP.create("Vendor-Specific-Application-Id",
                       [AVP.create("Vendor-Id", 10415),
                        AVP.create("Auth-Application-Id", 16777216)]),
            AVP.create("Session-Id", "one"),
            AVP.create("Destination-Host", "rkd2.local"),
            Severity: Major
            Found in functional_test/basic_stacks.rb and 1 other location - About 1 hr to fix
            functional_test/basic_stacks.rb on lines 59..72

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                avps = [AVP.create("Vendor-Specific-Application-Id",
                       [AVP.create("Vendor-Id", 10415),
                        AVP.create("Auth-Application-Id", 16777216)]),
            AVP.create("Session-Id", "one"),
            AVP.create("Destination-Host", "rkd2.local"),
            Severity: Major
            Found in functional_test/basic_stacks.rb and 1 other location - About 1 hr to fix
            functional_test/basic_stacks.rb on lines 33..46

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method main_loop has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def main_loop
          rs, _ws, es = IO.select(@all_connections + [@wakeup_pipe_rd], [], @all_connections)

        es.each do |e|
          # :nocov:
            Severity: Minor
            Found in lib/diameter/stack_transport_helpers.rb - About 1 hr to fix

              Method main_loop has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                    def main_loop
          rs, _ws, es = IO.select(@all_connections + [@wakeup_pipe_rd], [], @all_connections)

        es.each do |e|
          # :nocov:
              Severity: Minor
              Found in lib/diameter/stack_transport_helpers.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method create_answer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def create_answer(result_code, opts={})
      fail "Cannot answer an answer" if answer
      
      avps = []
      avps << avp_by_name("Session-Id") unless avp_by_name("Session-Id").nil?
              Severity: Minor
              Found in lib/diameter/message.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method app_avps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def app_avps
      avps = []
      
      @auth_apps.each do |app_id, vendor|
        avps << if vendor == 0
              Severity: Minor
              Found in lib/diameter/stack.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    @auth_apps.each do |app_id, vendor|
        avps << if vendor == 0
                  AVP.create("Auth-Application-Id", app_id)
                else
                  AVP.create("Vendor-Specific-Application-Id",
              Severity: Minor
              Found in lib/diameter/stack.rb and 1 other location - About 15 mins to fix
              lib/diameter/stack.rb on lines 329..335

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    @acct_apps.each do |app_id, vendor|
        avps << if vendor == 0
                  AVP.create("Acct-Application-Id", app_id)
                else
                  AVP.create("Vendor-Specific-Application-Id",
              Severity: Minor
              Found in lib/diameter/stack.rb and 1 other location - About 15 mins to fix
              lib/diameter/stack.rb on lines 319..325

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language