rmosolgo/graphql-ruby

View on GitHub

Showing 296 of 381 total issues

Method build_suite has 489 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.build_suite(&block)
        Class.new(Minitest::Test) do
          @@parse_fn = block

          def parse(query_string)
Severity: Major
Found in lib/graphql/compatibility/schema_parser_specification.rb - About 2 days to fix

    File schema.rb has 805 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "graphql/schema/base_64_encoder"
    require "graphql/schema/catchall_middleware"
    require "graphql/schema/default_parse_error"
    require "graphql/schema/default_type_error"
    require "graphql/schema/finder"
    Severity: Major
    Found in lib/graphql/schema.rb - About 1 day to fix

      Class Schema has 98 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Schema
          extend Forwardable
          extend GraphQL::Schema::Member::AcceptsDefinition
          include GraphQL::Define::InstanceDefinable
          accepts_definitions \
      Severity: Major
      Found in lib/graphql/schema.rb - About 1 day to fix

        Method build_suite has 345 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def self.build_suite(execution_strategy)
                Class.new(Minitest::Test) do
                  class << self
                    attr_accessor :counter_schema, :specification_schema
                  end
        Severity: Major
        Found in lib/graphql/compatibility/execution_specification.rb - About 1 day to fix

          File member.rb has 664 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          begin
            require 'parser/current'
          rescue LoadError
            raise LoadError, "GraphQL::Upgrader requires the 'parser' gem, please install it and/or add it to your Gemfile"
          end
          Severity: Major
          Found in lib/graphql/upgrader/member.rb - About 1 day to fix

            File schema_parser_specification.rb has 520 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            module GraphQL
              module Compatibility
                # This asserts that a given parse function turns a string into
                # the proper tree of {{GraphQL::Language::Nodes}}.
                module SchemaParserSpecification
            Severity: Major
            Found in lib/graphql/compatibility/schema_parser_specification.rb - About 1 day to fix

              File nodes.rb has 507 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              module GraphQL
                module Language
                  module Nodes
                    # {AbstractNode} is the base class for all nodes in a GraphQL AST.
                    #
              Severity: Major
              Found in lib/graphql/language/nodes.rb - About 1 day to fix

                Method build_suite has 186 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def self.build_suite(execution_strategy)
                        Class.new(Minitest::Test) do
                          class << self
                            attr_accessor :lazy_schema
                          end
                Severity: Major
                Found in lib/graphql/compatibility/lazy_execution_specification.rb - About 7 hrs to fix

                  File runtime.rb has 464 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  module GraphQL
                    module Execution
                      class Interpreter
                        # I think it would be even better if we could somehow make
                        # `continue_field` not recursive. "Trampolining" it somehow.
                  Severity: Minor
                  Found in lib/graphql/execution/interpreter/runtime.rb - About 7 hrs to fix

                    File field.rb has 447 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require "graphql/schema/field/connection_extension"
                    require "graphql/schema/field/scope_extension"
                    
                    module GraphQL
                      class Schema
                    Severity: Minor
                    Found in lib/graphql/schema/field.rb - About 6 hrs to fix

                      Method apply has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
                      Open

                            def apply(input_text)
                              input_text.scan(/(?:input_field|field|return_field|connection|argument) .*$/).each do |field|
                                matches = /(?<field_type>input_field|return_field|field|connection|argument) :(?<name>[a-zA-Z_0-9_]*)?(:?, +(?<return_type>([A-Za-z\[\]\.\!_0-9\(\)]|::|-> ?\{ ?| ?\})+))?(?<remainder>( |,|$).*)/.match(field)
                                if matches
                                  name = matches[:name]
                      Severity: Minor
                      Found in lib/graphql/upgrader/member.rb - About 6 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method resolve_with_support has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                      Open

                            def resolve_with_support(**args)
                              # First call the ready? hook which may raise
                              ready_val = if args.any?
                                ready?(**args)
                              else
                      Severity: Minor
                      Found in lib/graphql/schema/resolver.rb - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method build has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                      Open

                              def build(document, default_resolve: DefaultResolve)
                                raise InvalidDocumentError.new('Must provide a document ast.') if !document || !document.is_a?(GraphQL::Language::Nodes::Document)
                      
                                if default_resolve.is_a?(Hash)
                                  default_resolve = ResolveMap.new(default_resolve)
                      Severity: Minor
                      Found in lib/graphql/schema/build_from_definition.rb - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method on_argument has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                      Open

                            def on_argument(node, parent)
                              parent_defn = case parent
                              when GraphQL::Language::Nodes::InputObject
                                arg_defn = context.argument_definition
                                if arg_defn.nil?

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method build has 123 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              def self.build(execution_strategy)
                                organization_type = nil
                      
                                timestamp_type = GraphQL::ScalarType.define do
                                  name "Timestamp"

                        Method initialize has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
                        Open

                              def initialize(type: nil, name: nil, owner: nil, null: nil, field: nil, function: nil, description: nil, deprecation_reason: nil, method: nil, hash_key: nil, resolver_method: nil, resolve: nil, connection: nil, max_page_size: nil, scope: nil, introspection: false, camelize: true, trace: nil, complexity: 1, extras: [], extensions: [], resolver_class: nil, subscription_scope: nil, relay_node_field: false, relay_nodes_field: false, arguments: {}, &definition_block)
                                if name.nil?
                                  raise ArgumentError, "missing first `name` argument or keyword `name:`"
                                end
                                if !(field || function || resolver_class)
                        Severity: Minor
                        Found in lib/graphql/schema/field.rb - About 4 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        File execution_specification.rb has 355 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        require "graphql/compatibility/execution_specification/counter_schema"
                        require "graphql/compatibility/execution_specification/specification_schema"
                        
                        module GraphQL
                          module Compatibility
                        Severity: Minor
                        Found in lib/graphql/compatibility/execution_specification.rb - About 4 hrs to fix

                          Method resolve has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def resolve(object, args, ctx)
                                  if @resolve_proc
                                    raise "Can't run resolve proc for #{path} when using GraphQL::Execution::Interpreter"
                                  end
                                  begin
                          Severity: Minor
                          Found in lib/graphql/schema/field.rb - About 4 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Class Printer has 34 methods (exceeds 20 allowed). Consider refactoring.
                          Open

                              class Printer
                                # Turn an arbitrary AST node back into a string.
                                #
                                # @example Turning a document into a query string
                                #    document = GraphQL.parse(query_string)
                          Severity: Minor
                          Found in lib/graphql/language/printer.rb - About 4 hrs to fix

                            Method evaluate_selections has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
                            Open

                                    def evaluate_selections(path, owner_object, owner_type, selections, root_operation_type: nil)
                                      selections_by_name = {}
                                      gather_selections(owner_object, owner_type, selections, selections_by_name)
                                      selections_by_name.each do |result_name, field_ast_nodes_or_ast_node|
                                        # As a performance optimization, the hash key will be a `Node` if
                            Severity: Minor
                            Found in lib/graphql/execution/interpreter/runtime.rb - About 4 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language