rofrischmann/inline-style-prefixer

View on GitHub
benchmark/packages/301/utils/getBrowserInformation.js

Summary

Maintainability
F
3 days
Test Coverage

Function getBrowserInformation has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getBrowserInformation(userAgent) {
  var browserInfo = _bowser2.default._detect(userAgent);

  for (var browser in prefixByBrowser) {
    if (browserInfo.hasOwnProperty(browser)) {
Severity: Minor
Found in benchmark/packages/301/utils/getBrowserInformation.js - About 1 hr to fix

    Function getBrowserName has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function getBrowserName(browserInfo) {
      if (browserInfo.firefox) {
        return 'firefox';
      }
    
    
    Severity: Minor
    Found in benchmark/packages/301/utils/getBrowserInformation.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getBrowserInformation has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    function getBrowserInformation(userAgent) {
      var browserInfo = _bowser2.default._detect(userAgent);
    
      for (var browser in prefixByBrowser) {
        if (browserInfo.hasOwnProperty(browser)) {
    Severity: Minor
    Found in benchmark/packages/301/utils/getBrowserInformation.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return browserByCanIuseAlias[browser];
    Severity: Major
    Found in benchmark/packages/301/utils/getBrowserInformation.js - About 30 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function getBrowserInformation(userAgent) {
        var browserInfo = _bowser2.default._detect(userAgent);
      
        for (var browser in prefixByBrowser) {
          if (browserInfo.hasOwnProperty(browser)) {
      Severity: Major
      Found in benchmark/packages/301/utils/getBrowserInformation.js and 1 other location - About 2 days to fix
      benchmark/packages/302/utils/getBrowserInformation.js on lines 73..126

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 415.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      function getBrowserName(browserInfo) {
        if (browserInfo.firefox) {
          return 'firefox';
        }
      
      
      Severity: Major
      Found in benchmark/packages/301/utils/getBrowserInformation.js and 1 other location - About 4 hrs to fix
      benchmark/packages/302/utils/getBrowserInformation.js on lines 46..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

      var prefixByBrowser = {
        chrome: 'Webkit',
        safari: 'Webkit',
        ios: 'Webkit',
        android: 'Webkit',
      Severity: Major
      Found in benchmark/packages/301/utils/getBrowserInformation.js and 2 other locations - About 2 hrs to fix
      benchmark/packages/300/utils/getBrowserInformation.js on lines 14..32
      benchmark/packages/302/utils/getBrowserInformation.js on lines 14..32

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

      var browserByCanIuseAlias = {
        chrome: 'chrome',
        chromium: 'chrome',
        safari: 'safari',
        firfox: 'firefox',
      Severity: Major
      Found in benchmark/packages/301/utils/getBrowserInformation.js and 10 other locations - About 40 mins to fix
      benchmark/packages/205/plugins/flexboxIE.js on lines 24..33
      benchmark/packages/205/static/plugins/flexboxIE.js on lines 16..25
      benchmark/packages/300/dynamic/plugins/flexboxIE.js on lines 23..32
      benchmark/packages/300/static/plugins/flexboxIE.js on lines 13..22
      benchmark/packages/300/utils/getBrowserInformation.js on lines 35..44
      benchmark/packages/301/dynamic/plugins/flexboxIE.js on lines 23..32
      benchmark/packages/301/static/plugins/flexboxIE.js on lines 13..22
      benchmark/packages/302/dynamic/plugins/flexboxIE.js on lines 23..32
      benchmark/packages/302/static/plugins/flexboxIE.js on lines 13..22
      benchmark/packages/302/utils/getBrowserInformation.js on lines 35..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status