rom-rb/rom-factory

View on GitHub

Showing 4 of 4 total issues

Method extend_builder has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def extend_builder(name, parent, relation_name, ns, &block)
Severity: Minor
Found in lib/rom/factory/factories.rb - About 35 mins to fix

    Method evaluate_associations has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def evaluate_associations(attrs, opts)
            attributes.associations.each_with_object({}) do |assoc, h|
              if assoc.dependency?(relation)
                h[assoc.name] = ->(parent, call_opts) do
                  assoc.call(parent, **opts, **call_opts)
    Severity: Minor
    Found in lib/rom/factory/tuple_evaluator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def call(attrs = EMPTY_HASH, parent, persist: true)
              return if attrs.key?(name)
    
              struct = if persist && attrs[tpk]
                         attrs
    Severity: Minor
    Found in lib/rom/factory/attributes/association.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def call(attrs, persist: true)
              if attrs.key?(name) && !attrs[foreign_key]
                assoc.associate(attrs, attrs[name])
              elsif !attrs[foreign_key]
                struct = if persist
    Severity: Minor
    Found in lib/rom/factory/attributes/association.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language