Sign upLogin

ronin/payu

View on GitHub
Star

Showing 3 of 3 total issues

Method generate_signature has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def generate_signature
      Signature.generate(
        pos_id,
        pay_type,
        session_id,
Severity: Minor
Found in lib/payu/transaction.rb - About 1 hr to fix

    Method validate_options! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate_options!
      raise PosInvalid.new('Missing pos_id parameter') if pos_id.nil? || pos_id == 0
      raise PosInvalid.new('Missing pos_auth_key parameter') if pos_auth_key.nil? || pos_auth_key == ''
      raise PosInvalid.new('Missing key1 parameter') if key1.nil? || key1 == ''
      raise PosInvalid.new('Missing key2 parameter') if key2.nil? || key2 == ''
    Severity: Minor
    Found in lib/payu/pos.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method new_transaction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def new_transaction(options = {})
      options = options.dup

      options.merge!({
        :pos_id => @pos_id,
    Severity: Minor
    Found in lib/payu/pos.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language