roo-rb/roo-xls

View on GitHub

Showing 19 of 19 total issues

Method read_cells has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  def read_cells(sheet = nil)
    sheet ||= @default_sheet
    validate_sheet!(sheet)
    return if @cells_read[sheet]
    sheet_found = false
Severity: Minor
Found in lib/roo/xls/excel_2003_xml.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File excel.rb has 286 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'roo/xls/version'
require 'roo/base'
require 'spreadsheet'
require 'tmpdir'

Severity: Minor
Found in lib/roo/xls/excel.rb - About 2 hrs to fix

    Class Excel has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Excel < Roo::Base
        FORMULAS_MESSAGE = 'the spreadsheet gem does not support formulas, so roo can not.'
        CHARGUESS =
          begin
            require 'charguess'
    Severity: Minor
    Found in lib/roo/xls/excel.rb - About 2 hrs to fix

      Method initialize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(filename, options = {})
            packed = options[:packed]
            file_warning = options[:file_warning] || :error
            mode = options[:mode] || 'rb+'
      
      
      Severity: Minor
      Found in lib/roo/xls/excel.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_cells has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def read_cells(sheet = nil)
          sheet ||= @default_sheet
          validate_sheet!(sheet)
          return if @cells_read[sheet]
          sheet_found = false
      Severity: Major
      Found in lib/roo/xls/excel_2003_xml.rb - About 2 hrs to fix

        Method read_cells has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            def read_cells(sheet = default_sheet)
              validate_sheet!(sheet)
              return if @cells_read[sheet]
        
              worksheet = @workbook.worksheet(sheet_no(sheet))
        Severity: Minor
        Found in lib/roo/xls/excel.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method read_cell_date_or_time has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            def read_cell_date_or_time(row, idx)
              cell = read_cell_content(row, idx)
              cell = cell.to_s.to_f
              if cell < 1.0
                value_type = :time
        Severity: Minor
        Found in lib/roo/xls/excel.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method read_cell_date_or_time has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def read_cell_date_or_time(row, idx)
              cell = read_cell_content(row, idx)
              cell = cell.to_s.to_f
              if cell < 1.0
                value_type = :time
        Severity: Minor
        Found in lib/roo/xls/excel.rb - About 1 hr to fix

          Method set_cell_values has 10 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def set_cell_values(sheet, x, y, i, v, value_type, formula, _table_cell, str_v, style_name)
          Severity: Major
          Found in lib/roo/xls/excel_2003_xml.rb - About 1 hr to fix

            Method initialize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              def initialize(filename, options = {})
                packed = options[:packed]
                file_warning = options[:file_warning] || :error
            
                Dir.mktmpdir do |tmpdir|
            Severity: Minor
            Found in lib/roo/xls/excel_2003_xml.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method set_cell_values has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def set_cell_values(sheet, row, col, i, v, value_type, formula, _tr, font)
            Severity: Major
            Found in lib/roo/xls/excel.rb - About 1 hr to fix

              Method set_cell_values has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  def set_cell_values(sheet, row, col, i, v, value_type, formula, _tr, font)
                    # key = "#{y},#{x+i}"
                    key = [row, col + i]
                    @cell_type[sheet] = {} unless @cell_type[sheet]
                    @cell_type[sheet][key] = value_type
              Severity: Minor
              Found in lib/roo/xls/excel.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method set_cell_values has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def set_cell_values(sheet, x, y, i, v, value_type, formula, _table_cell, str_v, style_name)
                  key = [y, x + i]
                  @cell_type[sheet] = {} unless @cell_type[sheet]
                  @cell_type[sheet][key] = value_type
                  @formula[sheet] = {} unless @formula[sheet]
              Severity: Minor
              Found in lib/roo/xls/excel_2003_xml.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method each has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                    def each(skip = dimensions[0])
                      blanks = 0
                      skip.upto(dimensions[1] - 1) do |i|
                        if row(i).any?
                          Proc.new.call(row(i))
              Severity: Minor
              Found in lib/roo/xls/spreadsheet_extensions.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method children_to_string has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def children_to_string(children)
                  result = ''
                  children.each do|child|
                    if child.text?
                      result = result + child.content
              Severity: Minor
              Found in lib/roo/xls/excel_2003_xml.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method date_or_time? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def date_or_time?(row, idx)
                    format = row.format(idx)
                    if format.date_or_time?
                      cell = read_cell_content(row, idx)
                      true if Float(cell) > 0 rescue false
              Severity: Minor
              Found in lib/roo/xls/excel.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    if celltype(row, col, sheet) == :date
                      yyyy, mm, dd = @cell[sheet][[row, col]].split('-')
                      return Date.new(yyyy.to_i, mm.to_i, dd.to_i)
              Severity: Minor
              Found in lib/roo/xls/excel.rb and 1 other location - About 30 mins to fix
              lib/roo/xls/excel_2003_xml.rb on lines 42..44

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 32.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  if celltype(row, col, sheet) == :date
                    yyyy, mm, dd = @cell[sheet][[row, col]].split('-')
                    return Date.new(yyyy.to_i, mm.to_i, dd.to_i)
              Severity: Minor
              Found in lib/roo/xls/excel_2003_xml.rb and 1 other location - About 30 mins to fix
              lib/roo/xls/excel.rb on lines 78..80

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 32.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method cell has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def cell(row, col, sheet = default_sheet)
                    validate_sheet!(sheet)
              
                    read_cells(sheet)
                    raise 'should be read' unless @cells_read[sheet]
              Severity: Minor
              Found in lib/roo/xls/excel.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language