Showing 17 of 19 total issues
Method read_cells has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring. Open
def read_cells(sheet = nil)
sheet ||= @default_sheet
validate_sheet!(sheet)
return if @cells_read[sheet]
sheet_found = false- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File excel.rb has 286 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'roo/xls/version'
require 'roo/base'
require 'spreadsheet'
require 'tmpdir'
Class Excel has 25 methods (exceeds 20 allowed). Consider refactoring. Open
class Excel < Roo::Base
FORMULAS_MESSAGE = 'the spreadsheet gem does not support formulas, so roo can not.'
CHARGUESS =
begin
require 'charguess'Method initialize has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def initialize(filename, options = {})
packed = options[:packed]
file_warning = options[:file_warning] || :error
mode = options[:mode] || 'rb+'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method read_cells has 59 lines of code (exceeds 25 allowed). Consider refactoring. Open
def read_cells(sheet = nil)
sheet ||= @default_sheet
validate_sheet!(sheet)
return if @cells_read[sheet]
sheet_found = falseMethod read_cells has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def read_cells(sheet = default_sheet)
validate_sheet!(sheet)
return if @cells_read[sheet]
worksheet = @workbook.worksheet(sheet_no(sheet))- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method read_cell_date_or_time has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def read_cell_date_or_time(row, idx)
cell = read_cell_content(row, idx)
cell = cell.to_s.to_f
if cell < 1.0
value_type = :time- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method read_cell_date_or_time has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def read_cell_date_or_time(row, idx)
cell = read_cell_content(row, idx)
cell = cell.to_s.to_f
if cell < 1.0
value_type = :timeMethod set_cell_values has 10 arguments (exceeds 4 allowed). Consider refactoring. Open
def set_cell_values(sheet, x, y, i, v, value_type, formula, _table_cell, str_v, style_name)Method initialize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def initialize(filename, options = {})
packed = options[:packed]
file_warning = options[:file_warning] || :error
Dir.mktmpdir do |tmpdir|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_cell_values has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
def set_cell_values(sheet, row, col, i, v, value_type, formula, _tr, font)Method set_cell_values has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def set_cell_values(sheet, x, y, i, v, value_type, formula, _table_cell, str_v, style_name)
key = [y, x + i]
@cell_type[sheet] = {} unless @cell_type[sheet]
@cell_type[sheet][key] = value_type
@formula[sheet] = {} unless @formula[sheet]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_cell_values has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def set_cell_values(sheet, row, col, i, v, value_type, formula, _tr, font)
# key = "#{y},#{x+i}"
key = [row, col + i]
@cell_type[sheet] = {} unless @cell_type[sheet]
@cell_type[sheet][key] = value_type- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method each has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def each(skip = dimensions[0])
blanks = 0
skip.upto(dimensions[1] - 1) do |i|
if row(i).any?
Proc.new.call(row(i))- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method children_to_string has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def children_to_string(children)
result = ''
children.each do|child|
if child.text?
result = result + child.content- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method date_or_time? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def date_or_time?(row, idx)
format = row.format(idx)
if format.date_or_time?
cell = read_cell_content(row, idx)
true if Float(cell) > 0 rescue false- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method cell has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def cell(row, col, sheet = default_sheet)
validate_sheet!(sheet)
read_cells(sheet)
raise 'should be read' unless @cells_read[sheet]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"