Sign upLogin

rpush/rpush

View on GitHub
Star
lib/rpush/client/active_model/apns/notification.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method as_json has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

          def as_json(options = nil) # rubocop:disable Metrics/AbcSize, Metrics/PerceivedComplexity
            json = ActiveSupport::OrderedHash.new

            if data && data.key?(MDM_KEY)
              json['mdm'] = data[MDM_KEY]
Severity: Minor
Found in lib/rpush/client/active_model/apns/notification.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method included has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

          def self.included(base)
            base.extend ClassMethods
            base.instance_eval do
              validates :device_token, presence: true
              validates :badge, numericality: true, allow_nil: true
Severity: Minor
Found in lib/rpush/client/active_model/apns/notification.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status