Method new_connection has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring. Open
def new_connection(config)
username = nil
if config[:jndi]
jndi = config[:jndi].to_s- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File jdbc_connection.rb has 440 lines of code (exceeds 250 allowed). Consider refactoring. Open
begin
require "java"
require "jruby"
# ojdbc7.jar or ojdbc6.jar file should be in application ./lib directory or in load path or in ENV['PATH']Method new_connection has 92 lines of code (exceeds 25 allowed). Consider refactoring. Open
def new_connection(config)
username = nil
if config[:jndi]
jndi = config[:jndi].to_sMethod get_ruby_value_from_result_set has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
def get_ruby_value_from_result_set(rset, i, type_name, get_lob_value = true)
case type_name
when :NUMBER
d = rset.getNUMBER(i)
if d.nil?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
if config[:jndi]
jndi = config[:jndi].to_s
ctx = javax.naming.InitialContext.new
ds = nil
Class JDBCConnection has 21 methods (exceeds 20 allowed). Consider refactoring. Open
class JDBCConnection < OracleEnhanced::Connection # :nodoc:
attr_accessor :active
alias :active? :active
attr_accessor :auto_retryMethod get_ruby_value_from_result_set has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
def get_ruby_value_from_result_set(rset, i, type_name, get_lob_value = true)
case type_name
when :NUMBER
d = rset.getNUMBER(i)
if d.nil?Method with_retry has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def with_retry(&block)
should_retry = auto_retry? && autocommit?
begin
yield if block_given?
rescue Java::JavaSql::SQLException => e- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method bind_param has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def bind_param(position, value)
case value
when Integer
@raw_statement.setLong(position, value)
when FloatMethod lob_to_ruby_value has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def lob_to_ruby_value(val)
case val
when ::Java::OracleSql::CLOB
if val.isEmptyLob
nil- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method select_no_retry has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def select_no_retry(sql, name = nil, return_column_names = false)
stmt = @raw_connection.prepareStatement(sql)
rset = stmt.executeQuery
# Reuse the same hash for all rows- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
if database && (using_tns_alias || host == "connection-string")
url = "jdbc:oracle:thin:@#{database}"
else
unless database.match?(/^(:|\/)/)
# assume database is a SID if no colon or slash are supplied (backward-compatibility)Identical blocks of code found in 2 locations. Consider refactoring. Open
def bind_params(*bind_vars)
index = 1
bind_vars.flatten.each do |var|
if Hash === var
var.each { |key, val| bind_param key, val }- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 28.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76