Sign upLogin

rsim/oracle-enhanced

View on GitHub
Star
lib/active_record/connection_adapters/oracle_enhanced/schema_creation.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method visit_TableDefinition has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

          def visit_TableDefinition(o)
            create_sql = +"CREATE#{' GLOBAL TEMPORARY' if o.temporary} TABLE #{quote_table_name(o.name)} "
            statements = o.columns.map { |c| accept c }
            statements << accept(o.primary_keys) if o.primary_keys
Severity: Minor
Found in lib/active_record/connection_adapters/oracle_enhanced/schema_creation.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add_column_options! has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

          def add_column_options!(sql, options)
            type = options[:type] || ((column = options[:column]) && column.type)
            type = type && type.to_sym
            # handle case of defaults for CLOB/NCLOB columns, which would otherwise get "quoted" incorrectly
            if options_include_default?(options)
Severity: Minor
Found in lib/active_record/connection_adapters/oracle_enhanced/schema_creation.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status