Sign upLogin

rspec/rspec-expectations

View on GitHub
Star
lib/rspec/matchers.rb

Summary

Maintainability
A
3 hrs
Test Coverage

File matchers.rb has 271 lines of code (exceeds 250 allowed). Consider refactoring. 

require 'rspec/support'
RSpec::Support.require_rspec_support 'matcher_definition'
RSpec::Support.define_optimized_require_for_rspec(:matchers) { |f| require_relative(f) }

%w[
Severity: Minor
Found in lib/rspec/matchers.rb - About 2 hrs to fix

    Method append_features has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. 

            def append_features(mod)
          return super if mod < self # `mod < self` indicates a re-inclusion.

          subclasses = ObjectSpace.each_object(Class).select { |c| c < mod && c < self }
          return super unless subclasses.any?
    Severity: Minor
    Found in lib/rspec/matchers.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method is_a_matcher? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. 

        def self.is_a_matcher?(obj)
      return true  if ::RSpec::Matchers::BuiltIn::BaseMatcher === obj
      begin
        return false if obj.respond_to?(:i_respond_to_everything_so_im_not_really_a_matcher)
      rescue NoMethodError
    Severity: Minor
    Found in lib/rspec/matchers.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category