Sign upLogin

ruby-json-schema/json-schema

View on GitHub
Star

Showing 97 of 97 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if schema
          schema.validate(data, fragments, processor, options)
        elsif uri
          message = "The referenced schema '#{uri.to_s}' cannot be found"
          validation_error(processor, message, fragments, current_schema, self, options[:record_errors])
Severity: Minor
Found in lib/json-schema/attributes/ref.rb and 1 other location - About 50 mins to fix
lib/json-schema/attributes/extends.rb on lines 12..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def self.validate(current_schema, data, fragments, processor, validator, options = {})
Severity: Minor
Found in lib/json-schema/attributes/formats/date_time_v4.rb - About 45 mins to fix

    Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def self.validate(current_schema, data, fragments, processor, validator, options = {})
    Severity: Minor
    Found in lib/json-schema/attributes/type.rb - About 45 mins to fix

      Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def self.validate(current_schema, data, fragments, processor, validator, options = {})
      Severity: Minor
      Found in lib/json-schema/attributes/type_v4.rb - About 45 mins to fix

        Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def self.validate(current_schema, data, fragments, processor, validator, options = {})
        Severity: Minor
        Found in lib/json-schema/attributes/enum.rb - About 45 mins to fix

          Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def self.validate(current_schema, data, fragments, processor, validator, options = {})
          Severity: Minor
          Found in lib/json-schema/attributes/uniqueitems.rb - About 45 mins to fix

            Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def self.validate(current_schema, data, fragments, processor, validator, options = {})
            Severity: Minor
            Found in lib/json-schema/attributes/patternproperties.rb - About 45 mins to fix

              Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def validate(current_schema, data, fragments, processor, validator, options = {})
              Severity: Minor
              Found in lib/json-schema/attributes/formats/custom.rb - About 45 mins to fix

                Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def self.validate(current_schema, data, fragments, processor, validator, options = {})
                Severity: Minor
                Found in lib/json-schema/attributes/extends.rb - About 45 mins to fix

                  Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def self.validate(current_schema, data, fragments, processor, validator, options = {})
                  Severity: Minor
                  Found in lib/json-schema/attributes/items.rb - About 45 mins to fix

                    Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          def self.validate(current_schema, data, fragments, processor, validator, options = {})
                    Severity: Minor
                    Found in lib/json-schema/attributes/divisibleby.rb - About 45 mins to fix

                      Method schema_from_fragment has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def schema_from_fragment(base_schema, fragment)
      schema_uri = base_schema.uri
      fragments = fragment.split('/').map { |f| f.gsub('~0', '~').gsub('~1', '/') }

      # ensure the first element was a hash, per the fragment spec
                      Severity: Minor
                      Found in lib/json-schema/validator.rb - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            def self.validate(current_schema, data, fragments, processor, validator, options = {})
                      Severity: Minor
                      Found in lib/json-schema/attributes/oneof.rb - About 45 mins to fix

                        Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                              def self.validate(current_schema, data, fragments, processor, validator, options = {})
                        Severity: Minor
                        Found in lib/json-schema/attributes/disallow.rb - About 45 mins to fix

                          Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                def self.validate(current_schema, data, fragments, processor, validator, options = {})
                          Severity: Minor
                          Found in lib/json-schema/attributes/allof.rb - About 45 mins to fix

                            Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                  def self.validate(current_schema, data, fragments, processor, validator, options = {})
                            Severity: Minor
                            Found in lib/json-schema/attributes/required.rb - About 45 mins to fix

                              Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                    def self.validate(current_schema, data, fragments, processor, validator, options = {})
                              Severity: Minor
                              Found in lib/json-schema/attributes/additionalproperties.rb - About 45 mins to fix

                                Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                      def self.validate(current_schema, data, fragments, processor, validator, options = {})
                                Severity: Minor
                                Found in lib/json-schema/attributes/formats/time.rb - About 45 mins to fix

                                  Method validate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                        def self.validate(current_schema, data, fragments, processor, validator, options = {})
                                  Severity: Minor
                                  Found in lib/json-schema/attributes/properties_optional.rb - About 45 mins to fix

                                    Method merge_missing_values has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                          def merge_missing_values(source, destination)
        case destination
        when Hash
          source.each do |key, source_value|
            destination_value = destination[key] || destination[key.to_sym]
                                    Severity: Minor
                                    Found in lib/json-schema/validator.rb - About 45 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language