Sign upLogin

rubygems/gemcutter

View on GitHub
Star

Showing 4 of 4 total issues

Method list_webhooks has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def list_webhooks
    resp = rubygems_api_request(:get, "api/v1/web_hooks.yaml") do |request|
      request.add_field("Authorization", Gem.configuration.rubygems_api_key)
    end
Severity: Minor
Found in lib/rubygems/commands/webhook_command.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method list_webhooks has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def list_webhooks
    resp = rubygems_api_request(:get, "api/v1/web_hooks.yaml") do |request|
      request.add_field("Authorization", Gem.configuration.rubygems_api_key)
    end
Severity: Minor
Found in lib/rubygems/commands/webhook_command.rb - About 1 hr to fix

    Method yank_api_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def yank_api_request(method, version, platform, api, api_key)
    Severity: Minor
    Found in lib/rubygems/commands/yank_command.rb - About 35 mins to fix

      Method execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def execute
    sign_in
    version   = get_version_from_requirements(options[:version])
    platform  = get_platform_from_requirements(options)
    api_key   = Gem.configuration.rubygems_api_key
      Severity: Minor
      Found in lib/rubygems/commands/yank_command.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language