rubygems/gems

View on GitHub

Showing 4 of 4 total issues

Class Client has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Client
    include Gems::Request
    attr_accessor(*Configuration::VALID_OPTIONS_KEYS)

    def initialize(options = {})
Severity: Minor
Found in lib/gems/client.rb - About 2 hrs to fix

    Method request has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def request(method, path, data, content_type, request_host = host) # rubocop:disable AbcSize, CyclomaticComplexity, MethodLength, ParameterLists, PerceivedComplexity
          path += hash_to_query_string(data) if %i[delete get].include? method
          uri = URI.parse [request_host, path].join
          request_class = Net::HTTP.const_get method.to_s.capitalize
          request = request_class.new uri.request_uri
    Severity: Minor
    Found in lib/gems/request.rb - About 1 hr to fix

      Method request has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def request(method, path, data, content_type, request_host = host) # rubocop:disable AbcSize, CyclomaticComplexity, MethodLength, ParameterLists, PerceivedComplexity
            path += hash_to_query_string(data) if %i[delete get].include? method
            uri = URI.parse [request_host, path].join
            request_class = Net::HTTP.const_get method.to_s.capitalize
            request = request_class.new uri.request_uri
      Severity: Minor
      Found in lib/gems/request.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method request has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def request(method, path, data, content_type, request_host = host) # rubocop:disable AbcSize, CyclomaticComplexity, MethodLength, ParameterLists, PerceivedComplexity
      Severity: Minor
      Found in lib/gems/request.rb - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language