rviney/ig_markets

View on GitHub
lib/ig_markets/cli/main.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method parse_date_time has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def parse_date_time(attributes, attribute, klass, format, display_format)
Severity: Minor
Found in lib/ig_markets/cli/main.rb - About 35 mins to fix

    Method begin_session has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def begin_session(options)
              platform = options[:demo] ? :demo : :live
    
              @dealing_platform ||= DealingPlatform.new
              @dealing_platform.session.log_sinks = [$stdout] if options[:verbose]
    Severity: Minor
    Found in lib/ig_markets/cli/main.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method filter_options has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def filter_options(options, whitelist)
              options.each_with_object({}) do |(key, value), new_hash|
                next unless whitelist.include? key.to_sym
    
                new_hash[key.to_sym] = value == key ? nil : value
    Severity: Minor
    Found in lib/ig_markets/cli/main.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_date_time has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def parse_date_time(attributes, attribute, klass, format, display_format)
              return unless attributes.key? attribute
    
              if !['', attribute.to_s].include? attributes[attribute].to_s
                begin
    Severity: Minor
    Found in lib/ig_markets/cli/main.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status